[fix]: Transacttion offer #26

Closed
vivian.d.simbrellang.com wants to merge 1 commits from fix_transaction_offer into master
3 changed files with 6 additions and 5 deletions
+1 -1
View File
@@ -35,10 +35,10 @@ class SelectOfferService(BaseService):
transaction_offer_id = validated_data.get("offerId")
transaction_id = validated_data.get("transactionId")
request_id = validated_data.get("requestId")
offer_id = int(transaction_offer_id[5:]) # The last part is int
#"offerId": "SAL30001129",
if SelectOfferService.validate_account_ownership(
account_id=account_id, customer_id=customer_id
+2
View File
@@ -6,6 +6,8 @@ from sqlalchemy.exc import IntegrityError
from sqlalchemy.orm import relationship
from dateutil.relativedelta import relativedelta
from datetime import timedelta
import logging
logger = logging.getLogger(__name__)
class Loan(db.Model):
+3 -4
View File
@@ -26,12 +26,11 @@ class TransactionOffer(db.Model):
)
@classmethod
def is_valid_transaction_offer(cls, transaction_offer, customer_id, product_id):
def is_valid_transaction_offer(cls, transaction_offer_id, customer_id, product_id):
transaction_offer = cls.query.filter_by(
id = transaction_offer,
id = transaction_offer_id,
customer_id = customer_id,
product_id = product_id
# product_id = product_id
# transaction_id = transaction_id,
).first()