Compare commits

...

8 Commits

Author SHA1 Message Date
Chinenye Nmoh e6d4a441b2 added loan_repayment_schedule 2025-11-20 21:17:32 +01:00
ameye e5d9310563 Merge branch 'error_handling' of DigiFi/digifi-BankToProductCore into master 2025-11-12 15:12:42 +00:00
VivianDee ad27a26aec Update offer_analysis.py 2025-11-12 16:00:43 +01:00
VivianDee 537b6d68f9 Update offer_analysis.py 2025-11-12 14:19:02 +01:00
ameye 7cb34a995b Merge branch 'error_handling' of DigiFi/digifi-BankToProductCore into master 2025-11-11 22:02:23 +00:00
VivianDee e78e7402c8 Update customer.py 2025-11-11 21:35:56 +01:00
CHIEFSOFT\ameye 8f82964b70 load_loan bug 2025-11-11 07:44:09 -05:00
CHIEFSOFT\ameye 771e8c00ed repayment updates 2025-11-11 07:27:04 -05:00
7 changed files with 32 additions and 14 deletions
+2 -1
View File
@@ -1,2 +1,3 @@
from .transaction_type import TransactionType
from .loan_status import LoanStatus
from .loan_status import LoanStatus
from .repayment_schedule_status import RepaymentScheduleStatus
@@ -0,0 +1,6 @@
from enum import Enum
class RepaymentScheduleStatus(str, Enum):
ACTIVE = "active"
PARTIALLY_PAID = "partially_paid"
REPAID = "repaid"
+2 -2
View File
@@ -93,8 +93,8 @@ def loan_status():
@jwt_required()
def repayment():
data = request.get_json()
logger.error(f"HERE 0000a **** ")
# logger.info(f"Repayment request received: {data}")
# logger.error(f"Loan Repayment Data: {data} ")
logger.info(f"Repayment request received: {data}")
response = RepaymentService.process_request(data)
return response
+7 -2
View File
@@ -180,7 +180,7 @@ class OfferAnalysis:
if real_eligible_amount < original_transaction_offer.min_amount:
logger.error(f"Max eligible amount ({real_eligible_amount}) is less than the minimum offer amount ({original_transaction_offer.min_amount}).")
raise ValueError("You are not eligible for a loan at this time.")
raise ValueError("You are not eligible for a loan at this time - Minimum amount not met.")
# if real_eligible_amount < 100:
# logger.error(f"Max eligible amount ({real_eligible_amount}) is less than the minimum offer amount ({original_transaction_offer.min_amount}).")
@@ -225,7 +225,8 @@ class OfferAnalysis:
if approved_amount < offer.min_amount:
logger.error(f"Max eligible amount ({approved_amount}) is less than the minimum offer amount ({offer.min_amount}).")
raise ValueError("You are not eligible for a loan at this time.")
continue
# raise ValueError("You are not eligible for a loan at this time.")
# if approved_amount < 100:
# logger.error(f"Max eligible amount ({approved_amount}) is less than the minimum offer amount ({offer.min_amount}).")
@@ -255,4 +256,8 @@ class OfferAnalysis:
"tenor": offer.tenor
})
if not eligible_offers:
logger.error("No eligible offers found for customer: {customer_id} - Minimum amount not met")
raise ValueError("You are not eligible for a loan at this time - Minimum amount not met")
return eligible_offers
+9 -6
View File
@@ -39,16 +39,17 @@ class RepaymentService(BaseService):
# customer = Customer.get_customer_with_loan_list(customer_id)
transaction_id = validated_data.get('transactionId')
initiated_by = validated_data.get('initiatedBy')
logger.error(f"HERE 0002a **** ")
logger.error(f"RepaymentService Received **** {data}")
if(RepaymentService.validate_account_ownership(account_id = account_id, customer_id = customer_id)):
logger.error(f"HERE 0001a **** ")
# Check loan exists
loan = Loan.get_customer_loan(loan_id = loan_id, customer_id = customer_id)
load_loan = Loan.get_customer_loan(loan_id = loan_id, customer_id = customer_id)
# Save the repayment details
repayment = Repayment.create_repayment(
customer_id = customer_id,
loan = loan,
loan = load_loan,
transaction_id = transaction_id
)
@@ -56,6 +57,8 @@ class RepaymentService(BaseService):
logger.error(f"Failed to save repayment details")
return ResponseHelper.error(result_description="Failed to save repayment details.")
loan_transaction_id = load_loan.transaction_id
#Update Loan status
Loan.update_status(loan_id = loan_id, status = LoanStatus.START_REPAY) # repay started by user
transaction = RepaymentService.log_transaction(validated_data = validated_data)
@@ -73,14 +76,14 @@ class RepaymentService(BaseService):
"Id": repayment.id,
"repayment_id": repayment.id,
"initiated_by": repayment.initiated_by,
"transactionId": transaction_id,
"transactionId": loan_transaction_id,
"customerId": customer_id,
"productId": loan.product_id,
"productId": load_loan.product_id,
"loanRef": loan_ref,
"debtId": loan_id
}
event_thread = Thread(target=RepaymentService.trigger_loan_repayment, args=(transaction_id,))
event_thread = Thread(target=RepaymentService.trigger_loan_repayment, args=(loan_transaction_id,))
event_thread.start()
# Call Kafka in a background thread
+3 -3
View File
@@ -47,11 +47,11 @@ class Customer(db.Model):
@classmethod
def create_customer(cls, id, msisdn, country_code, account_id, account_type='savings'):
if cls.query.filter_by(id=id).first():
raise ValueError("Customer already exists")
raise ValueError("Customer ID '{id}' already exists.")
elif Account.query.filter_by(id=account_id).first():
raise ValueError("Account already exists")
raise ValueError(f"Account ID '{account_id}' already exists.")
elif cls.query.filter_by(msisdn=msisdn).first():
raise ValueError("msisdn already exists")
raise ValueError("MSISDN '{msisdn}' already exists")
# Create the customer
customer = cls(
+3
View File
@@ -3,6 +3,7 @@ from app.extensions import db
from sqlalchemy.orm import relationship
from dateutil.relativedelta import relativedelta
from sqlalchemy.sql import func
from app.api.enums.repayment_schedule_status import RepaymentScheduleStatus
class LoanRepaymentSchedule(db.Model):
__tablename__ = 'loan_repayment_schedules'
@@ -51,6 +52,7 @@ class LoanRepaymentSchedule(db.Model):
installment_amount=round(loan.installment_amount, 2),
product_id = loan.product_id,
transaction_id = transaction_id,
paid_status = RepaymentScheduleStatus.ACTIVE,
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
@@ -70,6 +72,7 @@ class LoanRepaymentSchedule(db.Model):
'interestAmount': self.interest_amount,
'totalInstallment': self.total_installment,
'paid': self.paid,
'paidStatus': self.paid_status,
'paidAt': self.paid_at.isoformat() if self.paid_at else None
}