Update offer_analysis.py

app/api/services/eligibility_check.py

@@ -51,6 +51,13 @@ class EligibilityCheckService(BaseService):
                 
                 db.session.flush()
 
+                # Determine if there is any loan of 3MPC active
+                current_loan  =  EligibilityCheckService.get_current_active_loans_by_account_id(account_id = account_id)
+                if current_loan:
+                    logger.info(f"Account {current_loan.account_id} has active loan {current_loan}")
+                    if current_loan.product_id =='3MPC':
+                        return ResponseHelper.error(result_description="Max loan count for 3MPC reached")
+
                 # Determine Loan count
                 is_eligible = EligibilityCheckService.check_loan_limits(customer_id)
 
@@ -167,7 +174,12 @@ class EligibilityCheckService(BaseService):
             logger.error(f"An error occurred: {str(e)}", exc_info=True)
             db.session.rollback()
             return ResponseHelper.internal_server_error()
-        
+
+    @staticmethod
+    def get_current_active_loans_by_account_id(account_id):
+        current_loan  = Loan.get_current_active_loans_by_account_id(account_id)
+        return current_loan
+
 
     @staticmethod
     def check_loan_limits(customer_id):

app/api/services/offer_analysis.py

@@ -180,7 +180,7 @@ class OfferAnalysis:
 
                 if real_eligible_amount < original_transaction_offer.min_amount:
                     logger.error(f"Max eligible amount ({real_eligible_amount}) is less than the minimum offer amount ({original_transaction_offer.min_amount}).")
-                    raise ValueError("You are not eligible for a loan at this time.")
+                    raise ValueError("You are not eligible for a loan at this time - Minimum amount not met.")
 
                 # if real_eligible_amount < 100:
                 #     logger.error(f"Max eligible amount ({real_eligible_amount}) is less than the minimum offer amount ({original_transaction_offer.min_amount}).")
@@ -225,7 +225,8 @@ class OfferAnalysis:
 
             if approved_amount < offer.min_amount:
                     logger.error(f"Max eligible amount ({approved_amount}) is less than the minimum offer amount ({offer.min_amount}).")
-                    raise ValueError("You are not eligible for a loan at this time.")
+                    continue
+                    # raise ValueError("You are not eligible for a loan at this time.")
 
             # if approved_amount < 100:
             #         logger.error(f"Max eligible amount ({approved_amount}) is less than the minimum offer amount ({offer.min_amount}).")
@@ -255,4 +256,8 @@ class OfferAnalysis:
                 "tenor": offer.tenor
             })
 
+        if not eligible_offers:
+            logger.error("No eligible offers found for customer: {customer_id} - Minimum amount not met")
+            raise ValueError("You are not eligible for a loan at this time - Minimum amount not met")
+
         return eligible_offers

app/api/services/repayment.py

@@ -57,7 +57,7 @@ class RepaymentService(BaseService):
                         return ResponseHelper.error(result_description="Failed to save repayment details.")
 
                     #Update Loan status
-                    Loan.update_status(loan_id = loan_id, status = LoanStatus.START_REPAY) # repay started bu user
+                    Loan.update_status(loan_id = loan_id, status = LoanStatus.START_REPAY) # repay started by user
                     transaction = RepaymentService.log_transaction(validated_data = validated_data)
 
                     if not transaction:

app/models/customer.py

@@ -47,11 +47,11 @@ class Customer(db.Model):
     @classmethod
     def create_customer(cls, id, msisdn, country_code, account_id, account_type='savings'):
         if cls.query.filter_by(id=id).first():
-            raise ValueError("Customer already exists")
+            raise ValueError("Customer ID '{id}' already exists.")
         elif Account.query.filter_by(id=account_id).first():
-            raise ValueError("Account already exists")
+            raise ValueError(f"Account ID '{account_id}' already exists.")
         elif cls.query.filter_by(msisdn=msisdn).first():
-            raise ValueError("msisdn already exists")
+            raise ValueError("MSISDN '{msisdn}'  already exists")
         
         # Create the customer
         customer = cls(

app/models/loan.py

@@ -1,5 +1,6 @@
 from datetime import datetime, timezone, timedelta
 from itertools import product
+from app.api.enums.loan_status import LoanStatus
 from app.extensions import db
 from app.models.customer import Customer
 from app.models.account import Account
@@ -192,13 +193,32 @@ class Loan(db.Model):
         Get all active loans with the same original_transaction ID.
         """
 
-        active_loans = cls.query.filter_by(
-        original_transaction=original_transaction_id,
-        # status='active'
+        active_loans = cls.query.filter(
+        cls.original_transaction == original_transaction_id,
+        or_(
+            cls.status == LoanStatus.ACTIVE.value,
+            cls.status == LoanStatus.START_REPAY.value,
+            cls.status == LoanStatus.ACTIVE_PARTIAL.value,
+        )
         ).all()
 
         return active_loans
 
+    @classmethod
+    def get_current_active_loans_by_account_id(cls, account_id):
+        """
+        Get the first active loan based on the accountID.
+        """
+        first_active_loan = cls.query.filter(
+        cls.account_id == account_id,
+        or_(
+            cls.status == LoanStatus.ACTIVE.value,
+            cls.status == LoanStatus.START_REPAY.value,
+            cls.status == LoanStatus.ACTIVE_PARTIAL.value,
+        )
+        ).order_by(cls.id.desc()).first()
+
+        return first_active_loan
 
     @classmethod
     def update_status(cls, loan_id, status):

app/models/repayment.py

@@ -36,9 +36,8 @@ class Repayment(db.Model):
     def create_repayment(cls, customer_id, loan, transaction_id):
         
         # Check that the loan is active
-        if loan.status not in [LoanStatus.ACTIVE, LoanStatus.START_REPAY]:
+        if loan.status not in [LoanStatus.ACTIVE, LoanStatus.START_REPAY, LoanStatus.ACTIVE_PARTIAL]:
             raise ValueError(f"Repayment cannot be processed. Loan status: ({loan.status})")
-        
 
         repayment = cls(
             customer_id=customer_id,

app/models/transaction.py

@@ -4,6 +4,12 @@ from app.models import account
 from sqlalchemy.exc import IntegrityError
 from sqlalchemy import and_, or_, not_
 from sqlalchemy.sql import func
+from app.api.enums import TransactionType
+
+import logging
+logger = logging.getLogger(__name__)
+
+
 
 class Transaction(db.Model):
     __tablename__ = 'transactions'
@@ -20,7 +26,7 @@ class Transaction(db.Model):
     phone_number = db.Column(db.String(50), nullable=True)
     created_at = db.Column(db.DateTime(timezone=True), server_default=func.now())
     updated_at = db.Column(db.DateTime(timezone=True), server_default=func.now(), onupdate=func.now())
-    
+
     def __repr__(self):
         return f'<Transaction {self.id}>'
 
@@ -30,17 +36,21 @@ class Transaction(db.Model):
         # if cls.query.filter_by(transaction_id=transaction_id).first():
         #     raise ValueError("Duplicate Transaction")
 
-        if cls.query.filter( and_( cls.transaction_id ==transaction_id, cls.type==type) ).first():
-            raise ValueError("Duplicate Transaction")
-
-
+        if cls.query.filter(and_(cls.transaction_id == transaction_id, cls.type == type)).first():
+            if type == TransactionType.REPAYMENT:
+                logger.info('Repayment transaction already exists :::: But we like to continue.')
+                now = datetime.now()
+                type = TransactionType.REPAYMENT + '.'+ now.strftime("%Y%m%d%H%M%S")
+                logger.info('Modify Type  :::: {0}'.format(type))
+            else:
+                raise ValueError("Duplicate Transaction")
 
         transaction = cls(
-            transaction_id = transaction_id,
-            customer_id = customer_id,
-            account_id = account_id,
-            type = type,
-            channel = channel,
+            transaction_id=transaction_id,
+            customer_id=customer_id,
+            account_id=account_id,
+            type=type,
+            channel=channel,
             created_at=datetime.now(timezone.utc),
             updated_at=datetime.now(timezone.utc)
         )
@@ -54,4 +64,4 @@ class Transaction(db.Model):
 
     @classmethod
     def get_transaction_by_id(cls, transaction_id):
-        return cls.query.get(transaction_id)
+        return cls.query.get(transaction_id)