[fix]: Select offer requested amount

This commit was merged in pull request #48.
This commit is contained in:
VivianDee
2025-06-16 15:40:50 +01:00
parent 51995a3e02
commit dc9415ff79
2 changed files with 19 additions and 5 deletions
+12 -5
View File
@@ -3,6 +3,7 @@ from marshmallow import ValidationError
from app.api.helpers.response_helper import ResponseHelper
from app.api.services.base_service import BaseService
from app.api.enums import TransactionType
from app.models.transaction_offers import TransactionOffer
from app.utils.logger import logger
from app.api.schemas.select_offer import SelectOfferSchema
from app.extensions import db
@@ -57,14 +58,20 @@ class SelectOfferService(BaseService):
# Get the offer by product ID
offer = Offer.get_offer_by_product_id(product_id)
transaction_offer = TransactionOffer.get_transaction_offer(transaction_offer_id=offer_id)
if not transaction_offer:
logger.error(f"offer {offer_id} not found for customer {customer_id} and transaction {transaction_id}.")
return ResponseHelper.error(result_description="Offer not found.")
db.session.flush()
if amount < offer.min_amount:
logger.error(f"The amount {amount} is less than the minimum allowed offer amount {offer.min_amount}.")
if amount < transaction_offer.min_amount:
logger.error(f"The amount {amount} is less than the minimum allowed offer amount {transaction_offer.min_amount}.")
return ResponseHelper.error(result_description="The amount is less than the minimum allowed offer amount.")
elif amount > offer.max_amount:
logger.error(f"The amount {amount} is greater than the minimum allowed offer amount {offer.min_amount}.")
return ResponseHelper.error(result_description="The amount is greater than the maximum allowed offer amount.")
elif amount > transaction_offer.eligible_amount:
logger.error(f"The amount {amount} is greater than the eligible offer amount {transaction_offer.eligible_amount}.")
return ResponseHelper.error(result_description="The amount is greater than the eligible offer amount.")
+7
View File
@@ -85,6 +85,13 @@ class TransactionOffer(db.Model):
return cls.query.filter_by(customer_id=customer_id) \
.order_by(cls.created_at.desc()) \
.first()
@classmethod
def get_transaction_offer(cls, transaction_offer_id):
"""
Returns a transaction offer by its ID.
"""
return cls.query.get(transaction_offer_id)