[add]: enforce content type json

This commit is contained in:
VivianDee
2025-03-21 12:12:20 +01:00
parent c0680b3098
commit 293d73518f
8 changed files with 38 additions and 26 deletions
+4
View File
@@ -132,3 +132,7 @@ TypeError: require_api_key() missing 1 required positional argument: 'f'
2025-03-21 09:41:16,993 - INFO - Processing Disbursement request
2025-03-21 09:41:16,995 - ERROR - Validation Error: {'requestId': ['Missing data for required field.'], 'productId': ['Missing data for required field.'], 'collectAmountMgtFee': ['Missing data for required field.'], 'collectAmountVAT': ['Missing data for required field.'], 'provideAmount': ['Missing data for required field.'], 'countryId': ['Missing data for required field.'], 'debtId': ['Missing data for required field.'], 'collectAmountInsurance': ['Missing data for required field.'], 'channel': ['Unknown field.'], 'lienAmount': ['Unknown field.'], '$type': ['Unknown field.'], 'msisdn': ['Unknown field.'], 'countryCode': ['Unknown field.']}
2025-03-21 09:48:19,845 - ERROR - Unauthorized access: Missing API key.
2025-03-21 10:32:19,196 - ERROR - Unauthorized access: Missing API key.
2025-03-21 10:46:47,209 - ERROR - Unauthorized access: Missing API key.
2025-03-21 11:05:50,287 - INFO - Processing Disbursement request
2025-03-21 11:05:50,290 - ERROR - Validation Error: {'debtId': ['Missing data for required field.'], 'requestId': ['Missing data for required field.'], 'productId': ['Missing data for required field.'], 'provideAmount': ['Missing data for required field.'], 'collectAmountInsurance': ['Missing data for required field.'], 'collectAmountVAT': ['Missing data for required field.'], 'countryId': ['Missing data for required field.'], 'collectAmountMgtFee': ['Missing data for required field.'], 'msisdn': ['Unknown field.'], 'channel': ['Unknown field.'], 'lienAmount': ['Unknown field.'], 'countryCode': ['Unknown field.'], '$type': ['Unknown field.']}
+2 -3
View File
@@ -2,7 +2,7 @@ from flask import Flask
from flask_cors import CORS
from app.config import Config
from app.routes import api
from app.errors import bad_request, method_not_allowed, not_found
from app.errors import method_not_allowed, unsupported_media_type
def create_app():
""" Factory function to create a Flask app instance """
@@ -19,8 +19,7 @@ def create_app():
# Error Handlers
app.register_error_handler(400, bad_request)
app.register_error_handler(404, not_found)
app.register_error_handler(405, method_not_allowed)
app.register_error_handler(415, unsupported_media_type)
return app
+1 -1
View File
@@ -1 +1 @@
from .handlers import bad_request, method_not_allowed, not_found
from .handlers import method_not_allowed, unsupported_media_type
+3
View File
@@ -9,3 +9,6 @@ def not_found(error):
def bad_request(error):
return ResponseHelper.bad_request(message="Bad Request")
def unsupported_media_type(error):
return ResponseHelper.error(message="Unsupported Media Type", status_code=415)
+3 -1
View File
@@ -1,2 +1,4 @@
from .verify_api_key import require_api_key
from .app_id_checker import require_app_id
from .app_id_checker import require_app_id
from .request_validator import validate_json
from .cors import enforce_json
+6 -7
View File
@@ -1,9 +1,8 @@
# app/middlewares/cors.py
from flask import request
from app.helpers.response_helper import ResponseHelper
def cors_headers(response):
"""Allow cross-origin requests"""
response.headers["Access-Control-Allow-Origin"] = "*"
response.headers["Access-Control-Allow-Methods"] = "GET, POST, PUT, PATCH, DELETE"
response.headers["Access-Control-Allow-Headers"] = "Authorization, Content-Type"
return response
def enforce_json():
"""Middleware to enforce JSON Content-Type for incoming requests"""
if request.method in ["POST", "PUT", "PATCH"] and request.content_type != "application/json":
return ResponseHelper.error( message="Content-Type must be application/json")
+13 -8
View File
@@ -1,11 +1,16 @@
# app/middlewares/request_validator.py
from functools import wraps
from flask import request
from app.helpers.response_helper import ResponseHelper
from app.utils.logger import logger
def validate_json():
"""Ensure request has valid JSON"""
if not request.is_json:
return ResponseHelper.error(
message="Request must be JSON",
status_code=415
)
def validate_json(f):
"""Decorator to ensure the request has a valid JSON body."""
@wraps(f)
def decorated_function(*args, **kwargs):
if not request.is_json:
logger.error("Invalid request: Request must be JSON.")
return ResponseHelper.error(message="Request must be JSON", status_code=415)
return f(*args, **kwargs)
return decorated_function
+6 -6
View File
@@ -11,18 +11,17 @@ from app.blueprints import (
NewTransactionCheckService,
)
from app.utils.logger import logger
from app.middlewares import require_api_key
from app.middlewares import require_app_id
from app.middlewares import require_api_key, require_app_id, enforce_json
api = Blueprint("api", __name__)
# @api.before_request
# def require_api_key_middleware():
# """Middleware applied globally to all API routes in this blueprint"""
# return require_api_key()
@api.before_request
def cors_middleware():
"""Middleware applied globally to all API routes in this blueprint"""
return enforce_json()
@@ -41,6 +40,7 @@ def rac_check():
@require_api_key
@require_app_id
def disbursement():
data = request.get_json()
# logger.info(f"Disbursement request received: {data}")
response = DisbursementService.process_request(data)