forked from DigiFi/digifi-BankToProductCore
[add]: Loan details and repayment fix
This commit is contained in:
Vendored
+24
-24
@@ -1,24 +1,24 @@
|
|||||||
{
|
// {
|
||||||
"editor.lineNumbers": "off",
|
// "editor.lineNumbers": "off",
|
||||||
"editor.padding.top": 3,
|
// "editor.padding.top": 3,
|
||||||
"editor.padding.bottom": 3,
|
// "editor.padding.bottom": 3,
|
||||||
"editor.formatOnSave": true,
|
// "editor.formatOnSave": true,
|
||||||
"editor.formatOnPaste": true,
|
// "editor.formatOnPaste": true,
|
||||||
"editor.fontSize": 14,
|
// "editor.fontSize": 14,
|
||||||
"editor.lineHeight": 4.5,
|
// "editor.lineHeight": 4.5,
|
||||||
"editor.suggestFontSize": 15,
|
// "editor.suggestFontSize": 15,
|
||||||
// "editor.suggestLineHeight": 4,
|
// // "editor.suggestLineHeight": 4,
|
||||||
"breadcrumbs.enabled": false,
|
// "breadcrumbs.enabled": false,
|
||||||
"workbench.tips.enabled": false,
|
// "workbench.tips.enabled": false,
|
||||||
"workbench.statusBar.visible": false,
|
// "workbench.statusBar.visible": false,
|
||||||
// "workbench.editor.showTabs": "single",
|
// // "workbench.editor.showTabs": "single",
|
||||||
"git.enableSmartCommit": true,
|
// "git.enableSmartCommit": true,
|
||||||
"workbench.editor.editorActionsLocation": "hidden",
|
// "workbench.editor.editorActionsLocation": "hidden",
|
||||||
// "workbench.activityBar.location": "hidden",
|
// // "workbench.activityBar.location": "hidden",
|
||||||
"workbench.editor.enablePreviewFromQuickOpen": false,
|
// "workbench.editor.enablePreviewFromQuickOpen": false,
|
||||||
"editor.lightbulb.enabled": "off",
|
// "editor.lightbulb.enabled": "off",
|
||||||
"editor.selectionHighlight": false,
|
// "editor.selectionHighlight": false,
|
||||||
"editor.overviewRulerBorder": false,
|
// "editor.overviewRulerBorder": false,
|
||||||
"editor.renderLineHighlight": "none",
|
// "editor.renderLineHighlight": "none",
|
||||||
"editor.occurrencesHighlight": "off"
|
// "editor.occurrencesHighlight": "off"
|
||||||
}
|
// }
|
||||||
|
|||||||
@@ -7,6 +7,7 @@ from app.utils.logger import logger
|
|||||||
from app.api.schemas.provide_loan import ProvideLoanSchema
|
from app.api.schemas.provide_loan import ProvideLoanSchema
|
||||||
from app.api.integrations import KafkaIntegration
|
from app.api.integrations import KafkaIntegration
|
||||||
from threading import Thread
|
from threading import Thread
|
||||||
|
from app.models.loan import Loan
|
||||||
|
|
||||||
|
|
||||||
class ProvideLoanService(BaseService):
|
class ProvideLoanService(BaseService):
|
||||||
@@ -32,8 +33,23 @@ class ProvideLoanService(BaseService):
|
|||||||
transaction_id = validated_data.get('transactionId')
|
transaction_id = validated_data.get('transactionId')
|
||||||
|
|
||||||
if (ProvideLoanService.validate_account_ownership(account_id = account_id, customer_id = customer_id)):
|
if (ProvideLoanService.validate_account_ownership(account_id = account_id, customer_id = customer_id)):
|
||||||
|
|
||||||
|
# Save the loan details here
|
||||||
|
loan_id = f"loan_{transaction.id}"
|
||||||
|
|
||||||
|
loan = Loan.create_loan(
|
||||||
|
id=loan_id,
|
||||||
|
customer_id=customer_id,
|
||||||
|
account_id=account_id,
|
||||||
|
product_id=validated_data.get('productId'),
|
||||||
|
principal_amount=validated_data.get('requestedAmount'),
|
||||||
|
status="active"
|
||||||
|
)
|
||||||
|
|
||||||
transaction = ProvideLoanService.log_transaction(validated_data = validated_data)
|
transaction = ProvideLoanService.log_transaction(validated_data = validated_data)
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
if not transaction:
|
if not transaction:
|
||||||
logger.error(f"Failed to log transaction")
|
logger.error(f"Failed to log transaction")
|
||||||
return jsonify({
|
return jsonify({
|
||||||
@@ -89,4 +105,3 @@ class ProvideLoanService(BaseService):
|
|||||||
KafkaIntegration.send_loan_request(loan_data = loan_data, request_id = request_id)
|
KafkaIntegration.send_loan_request(loan_data = loan_data, request_id = request_id)
|
||||||
KafkaIntegration.flush()
|
KafkaIntegration.flush()
|
||||||
|
|
||||||
|
|
||||||
|
|||||||
@@ -21,10 +21,12 @@ class RepaymentService(BaseService):
|
|||||||
"""
|
"""
|
||||||
try:
|
try:
|
||||||
validated_data = RepaymentService.validate_data(data, RepaymentSchema())
|
validated_data = RepaymentService.validate_data(data, RepaymentSchema())
|
||||||
account_id = validated_data.get('accountId')
|
|
||||||
customer_id = validated_data.get('customerId')
|
customer_id = validated_data.get('customerId')
|
||||||
|
customer = RepaymentService.get_or_create_customer(validated_data)
|
||||||
|
account = customer.accounts[0]
|
||||||
|
|
||||||
if (RepaymentService.validate_account_ownership(account_id = account_id, customer_id = customer_id)):
|
|
||||||
|
if (RepaymentService.validate_account_ownership(account_id = account.id, customer_id = customer_id)):
|
||||||
transaction = RepaymentService.log_transaction(validated_data = validated_data)
|
transaction = RepaymentService.log_transaction(validated_data = validated_data)
|
||||||
|
|
||||||
if not transaction:
|
if not transaction:
|
||||||
|
|||||||
@@ -20,11 +20,11 @@ class Customer(db.Model):
|
|||||||
)
|
)
|
||||||
|
|
||||||
@classmethod
|
@classmethod
|
||||||
def is_eligible(cls, customer_id):
|
def is_valid_customer(cls, customer_id):
|
||||||
customer = cls.query.filter_by(id=customer_id).first()
|
customer = cls.query.filter_by(id=customer_id).first()
|
||||||
if not customer:
|
if not customer:
|
||||||
return False, "Customer not found"
|
return False
|
||||||
return True, "Customer is eligible"
|
return True
|
||||||
|
|
||||||
@classmethod
|
@classmethod
|
||||||
def create_customer(cls, id, msisdn, country_code, account_id, account_type='savings'):
|
def create_customer(cls, id, msisdn, country_code, account_id, account_type='savings'):
|
||||||
|
|||||||
+32
-2
@@ -1,5 +1,7 @@
|
|||||||
from datetime import datetime, timezone
|
from datetime import datetime, timezone
|
||||||
from app.extensions import db
|
from app.extensions import db
|
||||||
|
from app.models.customer import Customer
|
||||||
|
from app.models.account import Account
|
||||||
|
|
||||||
|
|
||||||
class Loan(db.Model):
|
class Loan(db.Model):
|
||||||
@@ -15,6 +17,34 @@ class Loan(db.Model):
|
|||||||
updated_at = db.Column(db.DateTime, default=datetime.now(timezone.utc), onupdate=datetime.now(timezone.utc))
|
updated_at = db.Column(db.DateTime, default=datetime.now(timezone.utc), onupdate=datetime.now(timezone.utc))
|
||||||
|
|
||||||
|
|
||||||
|
@classmethod
|
||||||
|
def create_loan(cls, id, customer_id, account_id, product_id, principal_amount, status='pending'):
|
||||||
|
|
||||||
|
# Check if customer exists
|
||||||
|
is_valid = Customer.is_valid_customer(customer_id)
|
||||||
|
if not is_valid:
|
||||||
|
raise ValueError("Customer does not exist")
|
||||||
|
|
||||||
|
# # Check for active loans
|
||||||
|
# has_active_loans = cls.has_active_loans(customer_id)
|
||||||
|
# if has_active_loans:
|
||||||
|
# raise ValueError("Customer has active loans")
|
||||||
|
|
||||||
|
# Create and save the loan
|
||||||
|
loan = cls(
|
||||||
|
id=id,
|
||||||
|
customer_id=customer_id,
|
||||||
|
account_id=account_id,
|
||||||
|
product_id=product_id,
|
||||||
|
principal_amount=principal_amount,
|
||||||
|
status=status
|
||||||
|
)
|
||||||
|
|
||||||
|
db.session.add(loan)
|
||||||
|
db.session.commit()
|
||||||
|
return loan
|
||||||
|
|
||||||
|
|
||||||
@classmethod
|
@classmethod
|
||||||
def has_active_loans(cls, customer_id):
|
def has_active_loans(cls, customer_id):
|
||||||
active_loans = cls.query.filter_by(
|
active_loans = cls.query.filter_by(
|
||||||
@@ -23,8 +53,8 @@ class Loan(db.Model):
|
|||||||
).count()
|
).count()
|
||||||
|
|
||||||
if active_loans > 0:
|
if active_loans > 0:
|
||||||
return False, "Customer has active loans"
|
return False
|
||||||
return True, "No active loans"
|
return True
|
||||||
|
|
||||||
|
|
||||||
def __repr__(self):
|
def __repr__(self):
|
||||||
|
|||||||
Reference in New Issue
Block a user