first commit

mod/assign/submission/file/backup/moodle2/backup_assignsubmission_file_subplugin.class.php

@@ -0,0 +1,66 @@
+<?php
+// This file is part of Moodle - http://moodle.org/
+//
+// Moodle is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Moodle is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+
+/**
+ * This file contains the class for backup of this submission plugin
+ *
+ * @package assignsubmission_file
+ * @copyright 2012 NetSpot {@link http://www.netspot.com.au}
+ * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+
+defined('MOODLE_INTERNAL') || die();
+
+/**
+ * Provides the information to backup submission files
+ *
+ * This just adds its filearea to the annotations and records the number of files
+ *
+ * @package assignsubmission_file
+ * @copyright 2012 NetSpot {@link http://www.netspot.com.au}
+ * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+class backup_assignsubmission_file_subplugin extends backup_subplugin {
+
+    /**
+     * Returns the subplugin information to attach to submission element
+     * @return backup_subplugin_element
+     */
+    protected function define_submission_subplugin_structure() {
+
+        // Create XML elements.
+        $subplugin = $this->get_subplugin_element();
+        $subpluginwrapper = new backup_nested_element($this->get_recommended_name());
+        $subpluginelement = new backup_nested_element('submission_file',
+                                                      null,
+                                                      array('numfiles', 'submission'));
+
+        // Connect XML elements into the tree.
+        $subplugin->add_child($subpluginwrapper);
+        $subpluginwrapper->add_child($subpluginelement);
+
+        // Set source to populate the data.
+        $subpluginelement->set_source_table('assignsubmission_file',
+                                            array('submission' => backup::VAR_PARENTID));
+
+        // The parent is the submission.
+        $subpluginelement->annotate_files('assignsubmission_file',
+                                          'submission_files',
+                                          'submission');
+        return $subplugin;
+    }
+
+}

mod/assign/submission/file/backup/moodle2/restore_assignsubmission_file_subplugin.class.php

@@ -0,0 +1,77 @@
+<?php
+// This file is part of Moodle - http://moodle.org/
+//
+// Moodle is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Moodle is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+
+/**
+ * This file contains the class for restore of this submission plugin
+ *
+ * @package assignsubmission_file
+ * @copyright 2012 NetSpot {@link http://www.netspot.com.au}
+ * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+
+/**
+ * Restore subplugin class.
+ *
+ * Provides the necessary information
+ * needed to restore one assign_submission subplugin.
+ *
+ * @package assignsubmission_file
+ * @copyright 2012 NetSpot {@link http://www.netspot.com.au}
+ * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+class restore_assignsubmission_file_subplugin extends restore_subplugin {
+
+    /**
+     * Returns the paths to be handled by the subplugin at workshop level
+     * @return array
+     */
+    protected function define_submission_subplugin_structure() {
+
+        $paths = array();
+
+        $elename = $this->get_namefor('submission');
+        $elepath = $this->get_pathfor('/submission_file');
+        // We used get_recommended_name() so this works.
+        $paths[] = new restore_path_element($elename, $elepath);
+
+        return $paths;
+    }
+
+    /**
+     * Processes one submission_file element
+     * @param mixed $data
+     * @return void
+     */
+    public function process_assignsubmission_file_submission($data) {
+        global $DB;
+
+        $data = (object)$data;
+        $data->assignment = $this->get_new_parentid('assign');
+        $oldsubmissionid = $data->submission;
+        // The mapping is set in the restore for the core assign activity
+        // when a submission node is processed.
+        $data->submission = $this->get_mappingid('submission', $data->submission);
+
+        $DB->insert_record('assignsubmission_file', $data);
+
+        $this->add_related_files('assignsubmission_file',
+                                 'submission_files',
+                                 'submission',
+                                 null,
+                                 $oldsubmissionid);
+    }
+
+}

mod/assign/submission/file/classes/event/assessable_uploaded.php

@@ -0,0 +1,97 @@
+<?php
+// This file is part of Moodle - http://moodle.org/
+//
+// Moodle is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Moodle is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+
+/**
+ * The assignsubmission_file assessable uploaded event.
+ *
+ * @package    assignsubmission_file
+ * @copyright  2013 Frédéric Massart
+ * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+
+namespace assignsubmission_file\event;
+
+defined('MOODLE_INTERNAL') || die();
+
+/**
+ * The assignsubmission_file assessable uploaded event class.
+ *
+ * @package    assignsubmission_file
+ * @since      Moodle 2.6
+ * @copyright  2013 Frédéric Massart
+ * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+class assessable_uploaded extends \core\event\assessable_uploaded {
+
+    /**
+     * Legacy event files.
+     *
+     * @var array
+     */
+    protected $legacyfiles = array();
+
+    /**
+     * Returns description of what happened.
+     *
+     * @return string
+     */
+    public function get_description() {
+        return "The user with id '$this->userid' has uploaded a file to the submission with id '$this->objectid' " .
+            "in the assignment activity with course module id '$this->contextinstanceid'.";
+    }
+
+    /**
+     * Return localised event name.
+     *
+     * @return string
+     */
+    public static function get_name() {
+        return get_string('eventassessableuploaded', 'assignsubmission_file');
+    }
+
+    /**
+     * Get URL related to the action.
+     *
+     * @return \moodle_url
+     */
+    public function get_url() {
+        return new \moodle_url('/mod/assign/view.php', array('id' => $this->contextinstanceid));
+    }
+
+    /**
+     * Sets the legacy event data.
+     *
+     * @param \stdClass $legacyfiles legacy event data.
+     * @return void
+     */
+    public function set_legacy_files($legacyfiles) {
+        $this->legacyfiles = $legacyfiles;
+    }
+
+    /**
+     * Init method.
+     *
+     * @return void
+     */
+    protected function init() {
+        parent::init();
+        $this->data['objecttable'] = 'assign_submission';
+    }
+
+    public static function get_objectid_mapping() {
+        return array('db' => 'assign_submission', 'restore' => 'submission');
+    }
+}

mod/assign/submission/file/classes/event/submission_created.php

@@ -0,0 +1,88 @@
+<?php
+// This file is part of Moodle - http://moodle.org/
+//
+// Moodle is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Moodle is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+
+/**
+ * The assignsubmission_file submission_created event.
+ *
+ * @package    assignsubmission_file
+ * @copyright  2014 Adrian Greeve <adrian@moodle.com>
+ * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+
+namespace assignsubmission_file\event;
+
+defined('MOODLE_INTERNAL') || die();
+
+/**
+ * The assignsubmission_file submission_created event class.
+ *
+ * @property-read array $other {
+ *      Extra information about the event.
+ *
+ *      - int filesubmissioncount: The number of files uploaded.
+ * }
+ *
+ * @package    assignsubmission_file
+ * @since      Moodle 2.7
+ * @copyright  2014 Adrian Greeve <adrian@moodle.com>
+ * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+class submission_created extends \mod_assign\event\submission_created {
+
+    /**
+     * Init method.
+     */
+    protected function init() {
+        parent::init();
+        $this->data['objecttable'] = 'assignsubmission_file';
+    }
+
+    /**
+     * Returns non-localised description of what happened.
+     *
+     * @return string
+     */
+    public function get_description() {
+        $descriptionstring = "The user with id '$this->userid' created a file submission and uploaded " .
+            "'{$this->other['filesubmissioncount']}' file/s in the assignment with course module id " .
+            "'$this->contextinstanceid'";
+        if (!empty($this->other['groupid'])) {
+            $descriptionstring .= " for the group with id '{$this->other['groupid']}'.";
+        } else {
+            $descriptionstring .= ".";
+        }
+
+        return $descriptionstring;
+    }
+
+    /**
+     * Custom validation.
+     *
+     * @throws \coding_exception
+     * @return void
+     */
+    protected function validate_data() {
+        parent::validate_data();
+        if (!isset($this->other['filesubmissioncount'])) {
+            throw new \coding_exception('The \'filesubmissioncount\' value must be set in other.');
+        }
+    }
+
+    public static function get_objectid_mapping() {
+        // No mapping available for 'assignsubmission_file'.
+        return array('db' => 'assignsubmission_file', 'restore' => \core\event\base::NOT_MAPPED);
+    }
+}

mod/assign/submission/file/classes/event/submission_updated.php

@@ -0,0 +1,88 @@
+<?php
+// This file is part of Moodle - http://moodle.org/
+//
+// Moodle is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Moodle is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+
+/**
+ * The assignsubmission_file submission_updated event.
+ *
+ * @package    assignsubmission_file
+ * @copyright  2014 Adrian Greeve <adrian@moodle.com>
+ * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+
+namespace assignsubmission_file\event;
+
+defined('MOODLE_INTERNAL') || die();
+
+/**
+ * The assignsubmission_file submission_updated event class.
+ *
+ * @property-read array $other {
+ *      Extra information about the event.
+ *
+ *      - int filesubmissioncount: The number of files uploaded.
+ * }
+ *
+ * @package    assignsubmission_file
+ * @since      Moodle 2.7
+ * @copyright  2014 Adrian Greeve <adrian@moodle.com>
+ * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+class submission_updated extends \mod_assign\event\submission_updated {
+
+    /**
+     * Init method.
+     */
+    protected function init() {
+        parent::init();
+        $this->data['objecttable'] = 'assignsubmission_file';
+    }
+
+    /**
+     * Returns non-localised description of what happened.
+     *
+     * @return string
+     */
+    public function get_description() {
+        $descriptionstring = "The user with id '$this->userid' updated a file submission and uploaded " .
+            "'{$this->other['filesubmissioncount']}' file/s in the assignment with course module id " .
+            "'$this->contextinstanceid'";
+        if (!empty($this->other['groupid'])) {
+            $descriptionstring .= " for the group with id '{$this->other['groupid']}'.";
+        } else {
+            $descriptionstring .= ".";
+        }
+
+        return $descriptionstring;
+    }
+
+    /**
+     * Custom validation.
+     *
+     * @throws \coding_exception
+     * @return void
+     */
+    protected function validate_data() {
+        parent::validate_data();
+        if (!isset($this->other['filesubmissioncount'])) {
+            throw new \coding_exception('The \'filesubmissioncount\' value must be set in other.');
+        }
+    }
+
+    public static function get_objectid_mapping() {
+        // No mapping available for 'assignsubmission_file'.
+        return array('db' => 'assignsubmission_file', 'restore' => \core\event\base::NOT_MAPPED);
+    }
+}

mod/assign/submission/file/classes/privacy/provider.php

@@ -0,0 +1,180 @@
+<?php
+// This file is part of Moodle - http://moodle.org/
+//
+// Moodle is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Moodle is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+
+/**
+ * Privacy class for requesting user data.
+ *
+ * @package    assignsubmission_file
+ * @copyright  2018 Adrian Greeve <adrian@moodle.com>
+ * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+
+namespace assignsubmission_file\privacy;
+
+defined('MOODLE_INTERNAL') || die();
+
+require_once($CFG->dirroot . '/mod/assign/locallib.php');
+
+use \core_privacy\local\metadata\collection;
+use \core_privacy\local\request\writer;
+use \core_privacy\local\request\contextlist;
+use \mod_assign\privacy\assign_plugin_request_data;
+
+/**
+ * Privacy class for requesting user data.
+ *
+ * @package    assignsubmission_file
+ * @copyright  2018 Adrian Greeve <adrian@moodle.com>
+ * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+class provider implements
+        \core_privacy\local\metadata\provider,
+        \mod_assign\privacy\assignsubmission_provider,
+        \mod_assign\privacy\assignsubmission_user_provider {
+
+    /**
+     * Return meta data about this plugin.
+     *
+     * @param  collection $collection A list of information to add to.
+     * @return collection Return the collection after adding to it.
+     */
+    public static function get_metadata(collection $collection): collection {
+        $collection->link_subsystem('core_files', 'privacy:metadata:filepurpose');
+        return $collection;
+    }
+
+    /**
+     * This is covered by mod_assign provider and the query on assign_submissions.
+     *
+     * @param  int $userid The user ID that we are finding contexts for.
+     * @param  contextlist $contextlist A context list to add sql and params to for contexts.
+     */
+    public static function get_context_for_userid_within_submission(int $userid, contextlist $contextlist) {
+        // This is already fetched from mod_assign.
+    }
+
+    /**
+     * This is also covered by the mod_assign provider and it's queries.
+     *
+     * @param  \mod_assign\privacy\useridlist $useridlist An object for obtaining user IDs of students.
+     */
+    public static function get_student_user_ids(\mod_assign\privacy\useridlist $useridlist) {
+        // No need.
+    }
+
+    /**
+     * If you have tables that contain userids and you can generate entries in your tables without creating an
+     * entry in the assign_submission table then please fill in this method.
+     *
+     * @param  userlist $userlist The userlist object
+     */
+    public static function get_userids_from_context(\core_privacy\local\request\userlist $userlist) {
+        // Not required.
+    }
+
+    /**
+     * Export all user data for this plugin.
+     *
+     * @param  assign_plugin_request_data $exportdata Data used to determine which context and user to export and other useful
+     * information to help with exporting.
+     */
+    public static function export_submission_user_data(assign_plugin_request_data $exportdata) {
+        // We currently don't show submissions to teachers when exporting their data.
+        $context = $exportdata->get_context();
+        if ($exportdata->get_user() != null) {
+            return null;
+        }
+        $user = new \stdClass();
+        $assign = $exportdata->get_assign();
+        $plugin = $assign->get_plugin_by_type('assignsubmission', 'file');
+        $files = $plugin->get_files($exportdata->get_pluginobject(), $user);
+        foreach ($files as $file) {
+            $userid = $exportdata->get_pluginobject()->userid;
+            writer::with_context($exportdata->get_context())->export_file($exportdata->get_subcontext(), $file);
+
+            // Plagiarism data.
+            $coursecontext = $context->get_course_context();
+            \core_plagiarism\privacy\provider::export_plagiarism_user_data($userid, $context, $exportdata->get_subcontext(), [
+                'cmid' => $context->instanceid,
+                'course' => $coursecontext->instanceid,
+                'userid' => $userid,
+                'file' => $file
+            ]);
+        }
+    }
+
+    /**
+     * Any call to this method should delete all user data for the context defined in the deletion_criteria.
+     *
+     * @param  assign_plugin_request_data $requestdata Information useful for deleting user data.
+     */
+    public static function delete_submission_for_context(assign_plugin_request_data $requestdata) {
+        global $DB;
+
+        \core_plagiarism\privacy\provider::delete_plagiarism_for_context($requestdata->get_context());
+
+        $fs = get_file_storage();
+        $fs->delete_area_files($requestdata->get_context()->id, 'assignsubmission_file', ASSIGNSUBMISSION_FILE_FILEAREA);
+
+        // Delete records from assignsubmission_file table.
+        $DB->delete_records('assignsubmission_file', ['assignment' => $requestdata->get_assign()->get_instance()->id]);
+    }
+
+    /**
+     * A call to this method should delete user data (where practical) using the userid and submission.
+     *
+     * @param  assign_plugin_request_data $deletedata Details about the user and context to focus the deletion.
+     */
+    public static function delete_submission_for_userid(assign_plugin_request_data $deletedata) {
+        global $DB;
+
+        \core_plagiarism\privacy\provider::delete_plagiarism_for_user($deletedata->get_user()->id, $deletedata->get_context());
+
+        $submissionid = $deletedata->get_pluginobject()->id;
+
+        $fs = get_file_storage();
+        $fs->delete_area_files($deletedata->get_context()->id, 'assignsubmission_file', ASSIGNSUBMISSION_FILE_FILEAREA,
+                $submissionid);
+
+        $DB->delete_records('assignsubmission_file', ['assignment' => $deletedata->get_assignid(), 'submission' => $submissionid]);
+    }
+
+    /**
+     * Deletes all submissions for the submission ids / userids provided in a context.
+     * assign_plugin_request_data contains:
+     * - context
+     * - assign object
+     * - submission ids (pluginids)
+     * - user ids
+     * @param  assign_plugin_request_data $deletedata A class that contains the relevant information required for deletion.
+     */
+    public static function delete_submissions(assign_plugin_request_data $deletedata) {
+        global $DB;
+
+        \core_plagiarism\privacy\provider::delete_plagiarism_for_users($deletedata->get_userids(), $deletedata->get_context());
+
+        if (empty($deletedata->get_submissionids())) {
+            return;
+        }
+        $fs = get_file_storage();
+        list($sql, $params) = $DB->get_in_or_equal($deletedata->get_submissionids(), SQL_PARAMS_NAMED);
+        $fs->delete_area_files_select($deletedata->get_context()->id, 'assignsubmission_file', ASSIGNSUBMISSION_FILE_FILEAREA,
+                $sql, $params);
+
+        $params['assignid'] = $deletedata->get_assignid();
+        $DB->delete_records_select('assignsubmission_file', "assignment = :assignid AND submission $sql", $params);
+    }
+}

mod/assign/submission/file/db/access.php

@@ -0,0 +1,29 @@
+<?php
+// This file is part of Moodle - http://moodle.org/
+//
+// Moodle is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Moodle is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+
+/**
+ * Capability definitions for this module.
+ *
+ * @package   assignsubmission_file
+ * @copyright 2012 NetSpot {@link http://www.netspot.com.au}
+ * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+
+$capabilities = array(
+
+
+
+);

mod/assign/submission/file/db/install.xml

@@ -0,0 +1,21 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<XMLDB PATH="mod/assign/submission/file/db" VERSION="20120423" COMMENT="XMLDB file for Moodle mod/assign/submission/file"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:noNamespaceSchemaLocation="../../../../../lib/xmldb/xmldb.xsd"
+>
+  <TABLES>
+    <TABLE NAME="assignsubmission_file" COMMENT="Info about file submissions for assignments">
+      <FIELDS>
+        <FIELD NAME="id" TYPE="int" LENGTH="10" NOTNULL="true" SEQUENCE="true"/>
+        <FIELD NAME="assignment" TYPE="int" LENGTH="10" NOTNULL="true" DEFAULT="0" SEQUENCE="false"/>
+        <FIELD NAME="submission" TYPE="int" LENGTH="10" NOTNULL="true" DEFAULT="0" SEQUENCE="false"/>
+        <FIELD NAME="numfiles" TYPE="int" LENGTH="10" NOTNULL="true" DEFAULT="0" SEQUENCE="false" COMMENT="The number of files the student submitted."/>
+      </FIELDS>
+      <KEYS>
+        <KEY NAME="primary" TYPE="primary" FIELDS="id" COMMENT="The unique id for this submission info."/>
+        <KEY NAME="assignment" TYPE="foreign" FIELDS="assignment" REFTABLE="assign" REFFIELDS="id" COMMENT="The assignment instance this submission relates to"/>
+        <KEY NAME="submission" TYPE="foreign" FIELDS="submission" REFTABLE="assign_submission" REFFIELDS="id" COMMENT="The submission this file submission relates to."/>
+      </KEYS>
+    </TABLE>
+  </TABLES>
+</XMLDB>

mod/assign/submission/file/db/upgrade.php

@@ -0,0 +1,44 @@
+<?php
+// This file is part of Moodle - http://moodle.org/
+//
+// Moodle is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Moodle is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+
+/**
+ * Upgrade code for install
+ *
+ * @package   assignsubmission_file
+ * @copyright 2012 NetSpot {@link http://www.netspot.com.au}
+ * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+
+/**
+ * Stub for upgrade code
+ * @param int $oldversion
+ * @return bool
+ */
+function xmldb_assignsubmission_file_upgrade($oldversion) {
+    // Automatically generated Moodle v4.1.0 release upgrade line.
+    // Put any upgrade step following this.
+
+    // Automatically generated Moodle v4.2.0 release upgrade line.
+    // Put any upgrade step following this.
+
+    // Automatically generated Moodle v4.3.0 release upgrade line.
+    // Put any upgrade step following this.
+
+    // Automatically generated Moodle v4.4.0 release upgrade line.
+    // Put any upgrade step following this.
+
+    return true;
+}

mod/assign/submission/file/lang/en/assignsubmission_file.php

@@ -0,0 +1,50 @@
+<?php
+// This file is part of Moodle - http://moodle.org/
+//
+// Moodle is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Moodle is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+
+/**
+ * Strings for component 'assignsubmission_file', language 'en'
+ *
+ * @package   assignsubmission_file
+ * @copyright 2012 NetSpot {@link http://www.netspot.com.au}
+ * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+
+
+$string['acceptedfiletypes'] = 'Accepted file types';
+$string['acceptedfiletypes_help'] = 'Accepted file types can be restricted by entering a list of file extensions. If the field is left empty, then all file types are allowed.';
+$string['configmaxbytes'] = 'Maximum file size';
+$string['countfiles'] = '{$a} files';
+$string['default'] = 'Enabled by default';
+$string['default_help'] = 'If set, this submission method will be enabled by default for all new assignments.';
+$string['defaultacceptedfiletypes'] = 'Default accepted file types';
+$string['enabled'] = 'File submissions';
+$string['enabled_help'] = 'If enabled, students are able to upload one or more files as their submission.';
+$string['eventassessableuploaded'] = 'A file has been uploaded.';
+$string['file'] = 'File submissions';
+$string['maxbytes'] = 'Maximum file size';
+$string['maxfiles'] = 'Maximum files per submission';
+$string['maxfiles_help'] = 'If file submissions are enabled, each assignment can be set to accept up to this number of files for their submission.';
+$string['maxfilessubmission'] = 'Maximum number of uploaded files';
+$string['maxfilessubmission_help'] = 'If file submissions are enabled, each student will be able to upload up to this number of files for their submission.';
+$string['maximumsubmissionsize'] = 'Maximum submission size';
+$string['maximumsubmissionsize_help'] = 'Files uploaded by students may be up to this size.';
+$string['pluginname'] = 'File submissions';
+$string['privacy:metadata:filepurpose'] = 'The files loaded for this assignment submission';
+$string['siteuploadlimit'] = 'Site upload limit';
+$string['submissionfilearea'] = 'Uploaded submission files';
+
+// Deprecated since Moodle 4.3.
+$string['numfilesforlog'] = 'The number of file(s) : {$a} file(s).';

mod/assign/submission/file/lang/en/deprecated.txt

@@ -0,0 +1 @@
+numfilesforlog,assignsubmission_file

mod/assign/submission/file/lib.php

@@ -0,0 +1,89 @@
+<?php
+// This file is part of Moodle - http://moodle.org/
+//
+// Moodle is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Moodle is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+
+/**
+ * This file contains the moodle hooks for the submission file plugin
+ *
+ * @package   assignsubmission_file
+ * @copyright 2012 NetSpot {@link http://www.netspot.com.au}
+ * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+defined('MOODLE_INTERNAL') || die();
+
+/**
+ * Serves assignment submissions and other files.
+ *
+ * @param mixed $course course or id of the course
+ * @param mixed $cm course module or id of the course module
+ * @param context $context
+ * @param string $filearea
+ * @param array $args
+ * @param bool $forcedownload
+ * @param array $options - List of options affecting file serving.
+ * @return bool false if file not found, does not return if found - just send the file
+ */
+function assignsubmission_file_pluginfile($course,
+                                          $cm,
+                                          context $context,
+                                          $filearea,
+                                          $args,
+                                          $forcedownload,
+                                          array $options=array()) {
+    global $DB, $CFG;
+
+    if ($context->contextlevel != CONTEXT_MODULE) {
+        return false;
+    }
+
+    require_login($course, false, $cm);
+    $itemid = (int)array_shift($args);
+    $record = $DB->get_record('assign_submission',
+                              array('id'=>$itemid),
+                              'userid, assignment, groupid',
+                              MUST_EXIST);
+    $userid = $record->userid;
+    $groupid = $record->groupid;
+
+    require_once($CFG->dirroot . '/mod/assign/locallib.php');
+
+    $assign = new assign($context, $cm, $course);
+
+    if ($assign->get_instance()->id != $record->assignment) {
+        return false;
+    }
+
+    if ($assign->get_instance()->teamsubmission &&
+        !$assign->can_view_group_submission($groupid)) {
+        return false;
+    }
+
+    if (!$assign->get_instance()->teamsubmission &&
+        !$assign->can_view_submission($userid)) {
+        return false;
+    }
+
+    $relativepath = implode('/', $args);
+
+    $fullpath = "/{$context->id}/assignsubmission_file/$filearea/$itemid/$relativepath";
+
+    $fs = get_file_storage();
+    if (!($file = $fs->get_file_by_hash(sha1($fullpath))) || $file->is_directory()) {
+        return false;
+    }
+
+    // Download MUST be forced - security!
+    send_stored_file($file, 0, 0, true, $options);
+}

mod/assign/submission/file/locallib.php

@@ -0,0 +1,637 @@
+<?php
+// This file is part of Moodle - http://moodle.org/
+//
+// Moodle is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Moodle is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+
+/**
+ * This file contains the definition for the library class for file submission plugin
+ *
+ * This class provides all the functionality for the new assign module.
+ *
+ * @package assignsubmission_file
+ * @copyright 2012 NetSpot {@link http://www.netspot.com.au}
+ * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+
+use core_external\external_value;
+
+// File areas for file submission assignment.
+define('ASSIGNSUBMISSION_FILE_MAXSUMMARYFILES', 5);
+define('ASSIGNSUBMISSION_FILE_FILEAREA', 'submission_files');
+
+/**
+ * Library class for file submission plugin extending submission plugin base class
+ *
+ * @package   assignsubmission_file
+ * @copyright 2012 NetSpot {@link http://www.netspot.com.au}
+ * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+class assign_submission_file extends assign_submission_plugin {
+
+    /**
+     * Get the name of the file submission plugin
+     * @return string
+     */
+    public function get_name() {
+        return get_string('file', 'assignsubmission_file');
+    }
+
+    /**
+     * Get file submission information from the database
+     *
+     * @param int $submissionid
+     * @return mixed
+     */
+    private function get_file_submission($submissionid) {
+        global $DB;
+        return $DB->get_record('assignsubmission_file', array('submission'=>$submissionid));
+    }
+
+    /**
+     * Get the default setting for file submission plugin
+     *
+     * @param MoodleQuickForm $mform The form to add elements to
+     * @return void
+     */
+    public function get_settings(MoodleQuickForm $mform) {
+        global $CFG, $COURSE;
+
+        if ($this->assignment->has_instance()) {
+            $defaultmaxfilesubmissions = $this->get_config('maxfilesubmissions');
+            $defaultmaxsubmissionsizebytes = $this->get_config('maxsubmissionsizebytes');
+            $defaultfiletypes = $this->get_config('filetypeslist');
+        } else {
+            $defaultmaxfilesubmissions = get_config('assignsubmission_file', 'maxfiles');
+            $defaultmaxsubmissionsizebytes = get_config('assignsubmission_file', 'maxbytes');
+            $defaultfiletypes = get_config('assignsubmission_file', 'filetypes');
+        }
+        $defaultfiletypes = (string)$defaultfiletypes;
+
+        $settings = array();
+        $options = array();
+        for ($i = 1; $i <= get_config('assignsubmission_file', 'maxfiles'); $i++) {
+            $options[$i] = $i;
+        }
+
+        $name = get_string('maxfilessubmission', 'assignsubmission_file');
+        $mform->addElement('select', 'assignsubmission_file_maxfiles', $name, $options);
+        $mform->addHelpButton('assignsubmission_file_maxfiles',
+                              'maxfilessubmission',
+                              'assignsubmission_file');
+        $mform->setDefault('assignsubmission_file_maxfiles', $defaultmaxfilesubmissions);
+        $mform->hideIf('assignsubmission_file_maxfiles', 'assignsubmission_file_enabled', 'notchecked');
+
+        $choices = get_max_upload_sizes($CFG->maxbytes,
+                                        $COURSE->maxbytes,
+                                        get_config('assignsubmission_file', 'maxbytes'));
+
+        $settings[] = array('type' => 'select',
+                            'name' => 'maxsubmissionsizebytes',
+                            'description' => get_string('maximumsubmissionsize', 'assignsubmission_file'),
+                            'options'=> $choices,
+                            'default'=> $defaultmaxsubmissionsizebytes);
+
+        $name = get_string('maximumsubmissionsize', 'assignsubmission_file');
+        $mform->addElement('select', 'assignsubmission_file_maxsizebytes', $name, $choices);
+        $mform->addHelpButton('assignsubmission_file_maxsizebytes',
+                              'maximumsubmissionsize',
+                              'assignsubmission_file');
+        $mform->setDefault('assignsubmission_file_maxsizebytes', $defaultmaxsubmissionsizebytes);
+        $mform->hideIf('assignsubmission_file_maxsizebytes',
+                           'assignsubmission_file_enabled',
+                           'notchecked');
+
+        $name = get_string('acceptedfiletypes', 'assignsubmission_file');
+        $mform->addElement('filetypes', 'assignsubmission_file_filetypes', $name);
+        $mform->addHelpButton('assignsubmission_file_filetypes', 'acceptedfiletypes', 'assignsubmission_file');
+        $mform->setDefault('assignsubmission_file_filetypes', $defaultfiletypes);
+        $mform->hideIf('assignsubmission_file_filetypes', 'assignsubmission_file_enabled', 'notchecked');
+    }
+
+    /**
+     * Save the settings for file submission plugin
+     *
+     * @param stdClass $data
+     * @return bool
+     */
+    public function save_settings(stdClass $data) {
+        $this->set_config('maxfilesubmissions', $data->assignsubmission_file_maxfiles);
+        $this->set_config('maxsubmissionsizebytes', $data->assignsubmission_file_maxsizebytes);
+
+        if (!empty($data->assignsubmission_file_filetypes)) {
+            $this->set_config('filetypeslist', $data->assignsubmission_file_filetypes);
+        } else {
+            $this->set_config('filetypeslist', '');
+        }
+
+        return true;
+    }
+
+    /**
+     * File format options
+     *
+     * @return array
+     */
+    private function get_file_options() {
+        $fileoptions = array('subdirs' => 1,
+                                'maxbytes' => $this->get_config('maxsubmissionsizebytes'),
+                                'maxfiles' => $this->get_config('maxfilesubmissions'),
+                                'accepted_types' => $this->get_configured_typesets(),
+                                'return_types' => (FILE_INTERNAL | FILE_CONTROLLED_LINK));
+        if ($fileoptions['maxbytes'] == 0) {
+            // Use module default.
+            $fileoptions['maxbytes'] = get_config('assignsubmission_file', 'maxbytes');
+        }
+        return $fileoptions;
+    }
+
+    /**
+     * Add elements to submission form
+     *
+     * @param mixed $submission stdClass|null
+     * @param MoodleQuickForm $mform
+     * @param stdClass $data
+     * @return bool
+     */
+    public function get_form_elements($submission, MoodleQuickForm $mform, stdClass $data) {
+        global $OUTPUT;
+
+        if ($this->get_config('maxfilesubmissions') <= 0) {
+            return false;
+        }
+
+        $fileoptions = $this->get_file_options();
+        $submissionid = $submission ? $submission->id : 0;
+
+        $data = file_prepare_standard_filemanager($data,
+                                                  'files',
+                                                  $fileoptions,
+                                                  $this->assignment->get_context(),
+                                                  'assignsubmission_file',
+                                                  ASSIGNSUBMISSION_FILE_FILEAREA,
+                                                  $submissionid);
+        $mform->addElement('filemanager', 'files_filemanager', $this->get_name(), null, $fileoptions);
+
+        return true;
+    }
+
+    /**
+     * Count the number of files
+     *
+     * @param int $submissionid
+     * @param string $area
+     * @return int
+     */
+    private function count_files($submissionid, $area) {
+        $fs = get_file_storage();
+        $files = $fs->get_area_files($this->assignment->get_context()->id,
+                                     'assignsubmission_file',
+                                     $area,
+                                     $submissionid,
+                                     'id',
+                                     false);
+
+        return count($files);
+    }
+
+    /**
+     * Save the files and trigger plagiarism plugin, if enabled,
+     * to scan the uploaded files via events trigger
+     *
+     * @param stdClass $submission
+     * @param stdClass $data
+     * @return bool
+     */
+    public function save(stdClass $submission, stdClass $data) {
+        global $USER, $DB;
+
+        $fileoptions = $this->get_file_options();
+
+        $data = file_postupdate_standard_filemanager($data,
+                                                     'files',
+                                                     $fileoptions,
+                                                     $this->assignment->get_context(),
+                                                     'assignsubmission_file',
+                                                     ASSIGNSUBMISSION_FILE_FILEAREA,
+                                                     $submission->id);
+
+        $filesubmission = $this->get_file_submission($submission->id);
+
+        // Plagiarism code event trigger when files are uploaded.
+
+        $fs = get_file_storage();
+        $files = $fs->get_area_files($this->assignment->get_context()->id,
+                                     'assignsubmission_file',
+                                     ASSIGNSUBMISSION_FILE_FILEAREA,
+                                     $submission->id,
+                                     'id',
+                                     false);
+
+        $count = $this->count_files($submission->id, ASSIGNSUBMISSION_FILE_FILEAREA);
+
+        $params = array(
+            'context' => context_module::instance($this->assignment->get_course_module()->id),
+            'courseid' => $this->assignment->get_course()->id,
+            'objectid' => $submission->id,
+            'other' => array(
+                'content' => '',
+                'pathnamehashes' => array_keys($files)
+            )
+        );
+        if (!empty($submission->userid) && ($submission->userid != $USER->id)) {
+            $params['relateduserid'] = $submission->userid;
+        }
+        if ($this->assignment->is_blind_marking()) {
+            $params['anonymous'] = 1;
+        }
+        $event = \assignsubmission_file\event\assessable_uploaded::create($params);
+        $event->set_legacy_files($files);
+        $event->trigger();
+
+        $groupname = null;
+        $groupid = 0;
+        // Get the group name as other fields are not transcribed in the logs and this information is important.
+        if (empty($submission->userid) && !empty($submission->groupid)) {
+            $groupname = $DB->get_field('groups', 'name', array('id' => $submission->groupid), MUST_EXIST);
+            $groupid = $submission->groupid;
+        } else {
+            $params['relateduserid'] = $submission->userid;
+        }
+
+        // Unset the objectid and other field from params for use in submission events.
+        unset($params['objectid']);
+        unset($params['other']);
+        $params['other'] = array(
+            'submissionid' => $submission->id,
+            'submissionattempt' => $submission->attemptnumber,
+            'submissionstatus' => $submission->status,
+            'filesubmissioncount' => $count,
+            'groupid' => $groupid,
+            'groupname' => $groupname
+        );
+
+        if ($filesubmission) {
+            $filesubmission->numfiles = $this->count_files($submission->id,
+                                                           ASSIGNSUBMISSION_FILE_FILEAREA);
+            $updatestatus = $DB->update_record('assignsubmission_file', $filesubmission);
+            $params['objectid'] = $filesubmission->id;
+
+            $event = \assignsubmission_file\event\submission_updated::create($params);
+            $event->set_assign($this->assignment);
+            $event->trigger();
+            return $updatestatus;
+        } else {
+            $filesubmission = new stdClass();
+            $filesubmission->numfiles = $this->count_files($submission->id,
+                                                           ASSIGNSUBMISSION_FILE_FILEAREA);
+            $filesubmission->submission = $submission->id;
+            $filesubmission->assignment = $this->assignment->get_instance()->id;
+            $filesubmission->id = $DB->insert_record('assignsubmission_file', $filesubmission);
+            $params['objectid'] = $filesubmission->id;
+
+            $event = \assignsubmission_file\event\submission_created::create($params);
+            $event->set_assign($this->assignment);
+            $event->trigger();
+            return $filesubmission->id > 0;
+        }
+    }
+
+    /**
+     * Remove files from this submission.
+     *
+     * @param stdClass $submission The submission
+     * @return boolean
+     */
+    public function remove(stdClass $submission) {
+        global $DB;
+        $fs = get_file_storage();
+
+        $fs->delete_area_files($this->assignment->get_context()->id,
+                               'assignsubmission_file',
+                               ASSIGNSUBMISSION_FILE_FILEAREA,
+                               $submission->id);
+
+        $currentsubmission = $this->get_file_submission($submission->id);
+        if ($currentsubmission) {
+            $currentsubmission->numfiles = 0;
+            $DB->update_record('assignsubmission_file', $currentsubmission);
+        }
+
+        return true;
+    }
+
+    /**
+     * Produce a list of files suitable for export that represent this feedback or submission
+     *
+     * @param stdClass $submission The submission
+     * @param stdClass $user The user record - unused
+     * @return array - return an array of files indexed by filename
+     */
+    public function get_files(stdClass $submission, stdClass $user) {
+        $result = array();
+        $fs = get_file_storage();
+
+        $files = $fs->get_area_files($this->assignment->get_context()->id,
+                                     'assignsubmission_file',
+                                     ASSIGNSUBMISSION_FILE_FILEAREA,
+                                     $submission->id,
+                                     'timemodified, id',
+                                     false);
+
+        foreach ($files as $file) {
+            // Do we return the full folder path or just the file name?
+            if (isset($submission->exportfullpath) && $submission->exportfullpath == false) {
+                $result[$file->get_filename()] = $file;
+            } else {
+                $result[$file->get_filepath().$file->get_filename()] = $file;
+            }
+        }
+        return $result;
+    }
+
+    /**
+     * Display the list of files  in the submission status table
+     *
+     * @param stdClass $submission
+     * @param bool $showviewlink Set this to true if the list of files is long
+     * @return string
+     */
+    public function view_summary(stdClass $submission, & $showviewlink) {
+        $count = $this->count_files($submission->id, ASSIGNSUBMISSION_FILE_FILEAREA);
+
+        // Show we show a link to view all files for this plugin?
+        $showviewlink = $count > ASSIGNSUBMISSION_FILE_MAXSUMMARYFILES;
+        if ($count <= ASSIGNSUBMISSION_FILE_MAXSUMMARYFILES) {
+            return $this->assignment->render_area_files('assignsubmission_file',
+                                                        ASSIGNSUBMISSION_FILE_FILEAREA,
+                                                        $submission->id);
+        } else {
+            return get_string('countfiles', 'assignsubmission_file', $count);
+        }
+    }
+
+    /**
+     * No full submission view - the summary contains the list of files and that is the whole submission
+     *
+     * @param stdClass $submission
+     * @return string
+     */
+    public function view(stdClass $submission) {
+        return $this->assignment->render_area_files('assignsubmission_file',
+                                                    ASSIGNSUBMISSION_FILE_FILEAREA,
+                                                    $submission->id);
+    }
+
+
+
+    /**
+     * Return true if this plugin can upgrade an old Moodle 2.2 assignment of this type
+     * and version.
+     *
+     * @param string $type
+     * @param int $version
+     * @return bool True if upgrade is possible
+     */
+    public function can_upgrade($type, $version) {
+
+        $uploadsingletype ='uploadsingle';
+        $uploadtype ='upload';
+
+        if (($type == $uploadsingletype || $type == $uploadtype) && $version >= 2011112900) {
+            return true;
+        }
+        return false;
+    }
+
+
+    /**
+     * Upgrade the settings from the old assignment
+     * to the new plugin based one
+     *
+     * @param context $oldcontext - the old assignment context
+     * @param stdClass $oldassignment - the old assignment data record
+     * @param string $log record log events here
+     * @return bool Was it a success? (false will trigger rollback)
+     */
+    public function upgrade_settings(context $oldcontext, stdClass $oldassignment, & $log) {
+        global $DB;
+
+        if ($oldassignment->assignmenttype == 'uploadsingle') {
+            $this->set_config('maxfilesubmissions', 1);
+            $this->set_config('maxsubmissionsizebytes', $oldassignment->maxbytes);
+            return true;
+        } else if ($oldassignment->assignmenttype == 'upload') {
+            $this->set_config('maxfilesubmissions', $oldassignment->var1);
+            $this->set_config('maxsubmissionsizebytes', $oldassignment->maxbytes);
+
+            // Advanced file upload uses a different setting to do the same thing.
+            $DB->set_field('assign',
+                           'submissiondrafts',
+                           $oldassignment->var4,
+                           array('id'=>$this->assignment->get_instance()->id));
+
+            // Convert advanced file upload "hide description before due date" setting.
+            $alwaysshow = 0;
+            if (!$oldassignment->var3) {
+                $alwaysshow = 1;
+            }
+            $DB->set_field('assign',
+                           'alwaysshowdescription',
+                           $alwaysshow,
+                           array('id'=>$this->assignment->get_instance()->id));
+            return true;
+        }
+    }
+
+    /**
+     * Upgrade the submission from the old assignment to the new one
+     *
+     * @param context $oldcontext The context of the old assignment
+     * @param stdClass $oldassignment The data record for the old oldassignment
+     * @param stdClass $oldsubmission The data record for the old submission
+     * @param stdClass $submission The data record for the new submission
+     * @param string $log Record upgrade messages in the log
+     * @return bool true or false - false will trigger a rollback
+     */
+    public function upgrade(context $oldcontext,
+                            stdClass $oldassignment,
+                            stdClass $oldsubmission,
+                            stdClass $submission,
+                            & $log) {
+        global $DB;
+
+        $filesubmission = new stdClass();
+
+        $filesubmission->numfiles = $oldsubmission->numfiles;
+        $filesubmission->submission = $submission->id;
+        $filesubmission->assignment = $this->assignment->get_instance()->id;
+
+        if (!$DB->insert_record('assignsubmission_file', $filesubmission) > 0) {
+            $log .= get_string('couldnotconvertsubmission', 'mod_assign', $submission->userid);
+            return false;
+        }
+
+        // Now copy the area files.
+        $this->assignment->copy_area_files_for_upgrade($oldcontext->id,
+                                                        'mod_assignment',
+                                                        'submission',
+                                                        $oldsubmission->id,
+                                                        $this->assignment->get_context()->id,
+                                                        'assignsubmission_file',
+                                                        ASSIGNSUBMISSION_FILE_FILEAREA,
+                                                        $submission->id);
+
+        return true;
+    }
+
+    /**
+     * The assignment has been deleted - cleanup
+     *
+     * @return bool
+     */
+    public function delete_instance() {
+        global $DB;
+        // Will throw exception on failure.
+        $DB->delete_records('assignsubmission_file',
+                            array('assignment'=>$this->assignment->get_instance()->id));
+
+        return true;
+    }
+
+    /**
+     * Return true if there are no submission files
+     * @param stdClass $submission
+     */
+    public function is_empty(stdClass $submission) {
+        return $this->count_files($submission->id, ASSIGNSUBMISSION_FILE_FILEAREA) == 0;
+    }
+
+    /**
+     * Determine if a submission is empty
+     *
+     * This is distinct from is_empty in that it is intended to be used to
+     * determine if a submission made before saving is empty.
+     *
+     * @param stdClass $data The submission data
+     * @return bool
+     */
+    public function submission_is_empty(stdClass $data) {
+        global $USER;
+        $fs = get_file_storage();
+        // Get a count of all the draft files, excluding any directories.
+        $files = $fs->get_area_files(context_user::instance($USER->id)->id,
+                                     'user',
+                                     'draft',
+                                     $data->files_filemanager,
+                                     'id',
+                                     false);
+        return count($files) == 0;
+    }
+
+    /**
+     * Get file areas returns a list of areas this plugin stores files
+     * @return array - An array of fileareas (keys) and descriptions (values)
+     */
+    public function get_file_areas() {
+        return array(ASSIGNSUBMISSION_FILE_FILEAREA=>$this->get_name());
+    }
+
+    /**
+     * Copy the student's submission from a previous submission. Used when a student opts to base their resubmission
+     * on the last submission.
+     * @param stdClass $sourcesubmission
+     * @param stdClass $destsubmission
+     */
+    public function copy_submission(stdClass $sourcesubmission, stdClass $destsubmission) {
+        global $DB;
+
+        // Copy the files across.
+        $contextid = $this->assignment->get_context()->id;
+        $fs = get_file_storage();
+        $files = $fs->get_area_files($contextid,
+                                     'assignsubmission_file',
+                                     ASSIGNSUBMISSION_FILE_FILEAREA,
+                                     $sourcesubmission->id,
+                                     'id',
+                                     false);
+        foreach ($files as $file) {
+            $fieldupdates = array('itemid' => $destsubmission->id);
+            $fs->create_file_from_storedfile($fieldupdates, $file);
+        }
+
+        // Copy the assignsubmission_file record.
+        if ($filesubmission = $this->get_file_submission($sourcesubmission->id)) {
+            unset($filesubmission->id);
+            $filesubmission->submission = $destsubmission->id;
+            $DB->insert_record('assignsubmission_file', $filesubmission);
+        }
+        return true;
+    }
+
+    /**
+     * Return a description of external params suitable for uploading a file submission from a webservice.
+     *
+     * @return \core_external\external_description|null
+     */
+    public function get_external_parameters() {
+        return array(
+            'files_filemanager' => new external_value(
+                PARAM_INT,
+                'The id of a draft area containing files for this submission.',
+                VALUE_OPTIONAL
+            )
+        );
+    }
+
+    /**
+     * Return the plugin configs for external functions.
+     *
+     * @return array the list of settings
+     * @since Moodle 3.2
+     */
+    public function get_config_for_external() {
+        global $CFG;
+
+        $configs = $this->get_config();
+
+        // Get a size in bytes.
+        if ($configs->maxsubmissionsizebytes == 0) {
+            $configs->maxsubmissionsizebytes = get_max_upload_file_size($CFG->maxbytes, $this->assignment->get_course()->maxbytes,
+                                                                        get_config('assignsubmission_file', 'maxbytes'));
+        }
+        return (array) $configs;
+    }
+
+    /**
+     * Get the type sets configured for this assignment.
+     *
+     * @return array('groupname', 'mime/type', ...)
+     */
+    private function get_configured_typesets() {
+        $typeslist = (string)$this->get_config('filetypeslist');
+
+        $util = new \core_form\filetypes_util();
+        $sets = $util->normalize_file_types($typeslist);
+
+        return $sets;
+    }
+
+    /**
+     * Determine if the plugin allows image file conversion
+     * @return bool
+     */
+    public function allow_image_conversion() {
+        return true;
+    }
+}

mod/assign/submission/file/settings.php

@@ -0,0 +1,51 @@
+<?php
+// This file is part of Moodle - http://moodle.org/
+//
+// Moodle is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Moodle is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+
+/**
+ * This file defines the admin settings for this plugin
+ *
+ * @package   assignsubmission_file
+ * @copyright 2012 NetSpot {@link http://www.netspot.com.au}
+ * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+
+
+// Note: This is on by default.
+$settings->add(new admin_setting_configcheckbox('assignsubmission_file/default',
+                   new lang_string('default', 'assignsubmission_file'),
+                   new lang_string('default_help', 'assignsubmission_file'), 1));
+
+$settings->add(new admin_setting_configtext('assignsubmission_file/maxfiles',
+                   new lang_string('maxfiles', 'assignsubmission_file'),
+                   new lang_string('maxfiles_help', 'assignsubmission_file'), 20, PARAM_INT));
+
+$settings->add(new admin_setting_filetypes('assignsubmission_file/filetypes',
+                   new lang_string('defaultacceptedfiletypes', 'assignsubmission_file'),
+                   new lang_string('acceptedfiletypes_help', 'assignsubmission_file'), ''));
+
+if (isset($CFG->maxbytes)) {
+
+    $name = new lang_string('maximumsubmissionsize', 'assignsubmission_file');
+    $description = new lang_string('configmaxbytes', 'assignsubmission_file');
+
+    $maxbytes = get_config('assignsubmission_file', 'maxbytes');
+    $element = new admin_setting_configselect('assignsubmission_file/maxbytes',
+                                              $name,
+                                              $description,
+                                              $CFG->maxbytes,
+                                              get_max_upload_sizes($CFG->maxbytes, 0, 0, $maxbytes));
+    $settings->add($element);
+}

mod/assign/submission/file/tests/behat/file_type_restriction.feature

@@ -0,0 +1,75 @@
+@mod @mod_assign @assignsubmission_file
+Feature: In an assignment, limit submittable file types
+  In order to constrain student submissions for marking
+  As a teacher
+  I need to limit the submittable file types
+
+  Background:
+    Given the following "courses" exist:
+      | fullname | shortname | category | groupmode |
+      | Course 1 | C1 | 0 | 1 |
+    And the following "users" exist:
+      | username | firstname | lastname | email |
+      | teacher1 | Teacher | 1 | teacher1@example.com |
+      | student1 | Student | 1 | student1@example.com |
+    And the following "course enrolments" exist:
+      | user | course | role |
+      | teacher1 | C1 | editingteacher |
+      | student1 | C1 | student |
+    And the following config values are set as admin:
+      | filetypes | image/png;spreadsheet | assignsubmission_file |
+
+  @javascript
+  Scenario: File types validation for an assignment
+    Given the following "activities" exist:
+      | activity | course | name                 | duedate    | assignsubmission_onlinetext_enabled | assignsubmission_file_enabled | assignsubmission_file_maxfiles | assignsubmission_file_maxsizebytes |
+      | assign   | C1     | Test assignment name | 1388534400 | 0                                   | 1                             | 1                              | 0                                  |
+    And I am on the "Test assignment name" Activity page logged in as teacher1
+    And I navigate to "Settings" in current page administration
+    When I set the field "Accepted file types" to "image/png;doesntexist;.anything;unreal/mimetype;nodot"
+    And I press "Save and display"
+    And I should see "Unknown file types: .doesntexist, .anything, unreal/mimetype, .nodot"
+    And I set the field "Accepted file types" to "image/png;spreadsheet"
+    And I press "Save and display"
+    And I navigate to "Settings" in current page administration
+    And the field "Accepted file types" matches value "image/png,spreadsheet"
+    And I set the field "Accepted file types" to ""
+    And I press "Choose"
+    And I set the field "Image files" to "1"
+    And I press "Save changes"
+    And I press "Save and display"
+    And I navigate to "Settings" in current page administration
+    Then the field "Accepted file types" matches value "image"
+
+  @javascript @_file_upload
+  Scenario: Uploading permitted file types for an assignment
+    Given the following "activities" exist:
+      | activity | course | name                 | duedate    | assignsubmission_onlinetext_enabled | assignsubmission_file_enabled | assignsubmission_file_maxfiles | assignsubmission_file_maxsizebytes | assignsubmission_file_filetypes |
+      | assign   | C1     | Test assignment name | 1388534400 | 0                                   | 1                             | 3                              | 0                                  | image/png,spreadsheet,.xml,.txt  |
+    And I am on the "Test assignment name" Activity page logged in as student1
+    When I press "Add submission"
+    And I should see "Accepted file types"
+    And I should see "Image (PNG)"
+    And I should see "Spreadsheet files"
+    And I should see "Text file"
+    And I upload "lib/tests/fixtures/gd-logo.png" file to "File submissions" filemanager
+    And I upload "lib/tests/fixtures/tabfile.csv" file to "File submissions" filemanager
+    And I upload "lib/tests/fixtures/empty.txt" file to "File submissions" filemanager
+    And I press "Save changes"
+    Then "gd-logo.png" "link" should exist
+    And "tabfile.csv" "link" should exist
+    And "empty.txt" "link" should exist
+
+  @javascript @_file_upload
+  Scenario: No filetypes allows all
+    Given the following "activities" exist:
+      | activity | course | name                 | duedate    | assignsubmission_onlinetext_enabled | assignsubmission_file_enabled | assignsubmission_file_maxfiles | assignsubmission_file_maxsizebytes | assignsubmission_file_filetypes |
+      | assign   | C1     | Test assignment name | 1388534400 | 0                                   | 1                             | 2                              | 0                                  |                                 |
+    And I am on the "Test assignment name" Activity page logged in as student1
+    When I press "Add submission"
+    And I should not see "Accepted file types"
+    And I upload "lib/tests/fixtures/gd-logo.png" file to "File submissions" filemanager
+    And I upload "lib/tests/fixtures/tabfile.csv" file to "File submissions" filemanager
+    And I press "Save changes"
+    Then "gd-logo.png" "link" should exist
+    And "tabfile.csv" "link" should exist

mod/assign/submission/file/tests/event/events_test.php

@@ -0,0 +1,213 @@
+<?php
+// This file is part of Moodle - http://moodle.org/
+//
+// Moodle is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Moodle is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+
+/**
+ * Contains the event tests for the plugin.
+ *
+ * @package   assignsubmission_file
+ * @copyright 2013 Frédéric Massart
+ * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+
+namespace assignsubmission_file\event;
+
+use mod_assign_test_generator;
+
+defined('MOODLE_INTERNAL') || die();
+
+global $CFG;
+require_once($CFG->dirroot . '/mod/assign/tests/generator.php');
+
+class events_test extends \advanced_testcase {
+
+    // Use the generator helper.
+    use mod_assign_test_generator;
+
+    /**
+     * Test that the assessable_uploaded event is fired when a file submission has been made.
+     */
+    public function test_assessable_uploaded(): void {
+        $this->resetAfterTest();
+
+        $course = $this->getDataGenerator()->create_course();
+        $student = $this->getDataGenerator()->create_and_enrol($course, 'student');
+        $assign = $this->create_instance($course);
+        $context = $assign->get_context();
+        $cm = $assign->get_course_module();
+
+        $this->setUser($student->id);
+        $submission = $assign->get_user_submission($student->id, true);
+
+        $fs = get_file_storage();
+        $dummy = (object) array(
+            'contextid' => $context->id,
+            'component' => 'assignsubmission_file',
+            'filearea' => ASSIGNSUBMISSION_FILE_FILEAREA,
+            'itemid' => $submission->id,
+            'filepath' => '/',
+            'filename' => 'myassignmnent.pdf'
+        );
+        $fi = $fs->create_file_from_string($dummy, 'Content of ' . $dummy->filename);
+        $dummy = (object) array(
+            'contextid' => $context->id,
+            'component' => 'assignsubmission_file',
+            'filearea' => ASSIGNSUBMISSION_FILE_FILEAREA,
+            'itemid' => $submission->id,
+            'filepath' => '/',
+            'filename' => 'myassignmnent.png'
+        );
+        $fi2 = $fs->create_file_from_string($dummy, 'Content of ' . $dummy->filename);
+        $files = $fs->get_area_files($context->id, 'assignsubmission_file', ASSIGNSUBMISSION_FILE_FILEAREA,
+            $submission->id, 'id', false);
+
+        $data = new \stdClass();
+        $plugin = $assign->get_submission_plugin_by_type('file');
+        $sink = $this->redirectEvents();
+        $plugin->save($submission, $data);
+        $events = $sink->get_events();
+
+        $this->assertCount(2, $events);
+        $event = reset($events);
+        $this->assertInstanceOf('\assignsubmission_file\event\assessable_uploaded', $event);
+        $this->assertEquals($context->id, $event->contextid);
+        $this->assertEquals($submission->id, $event->objectid);
+        $this->assertCount(2, $event->other['pathnamehashes']);
+        $this->assertEquals($fi->get_pathnamehash(), $event->other['pathnamehashes'][0]);
+        $this->assertEquals($fi2->get_pathnamehash(), $event->other['pathnamehashes'][1]);
+        $expected = new \stdClass();
+        $expected->modulename = 'assign';
+        $expected->cmid = $cm->id;
+        $expected->itemid = $submission->id;
+        $expected->courseid = $course->id;
+        $expected->userid = $student->id;
+        $expected->file = $files;
+        $expected->files = $files;
+        $expected->pathnamehashes = array($fi->get_pathnamehash(), $fi2->get_pathnamehash());
+        $this->assertEventContextNotUsed($event);
+    }
+
+    /**
+     * Test that the submission_created event is fired when a file submission is saved.
+     */
+    public function test_submission_created(): void {
+        $this->resetAfterTest();
+
+        $course = $this->getDataGenerator()->create_course();
+        $student = $this->getDataGenerator()->create_and_enrol($course, 'student');
+        $assign = $this->create_instance($course);
+        $context = $assign->get_context();
+
+        $this->setUser($student->id);
+        $submission = $assign->get_user_submission($student->id, true);
+
+        $fs = get_file_storage();
+        $dummy = (object) array(
+            'contextid' => $context->id,
+            'component' => 'assignsubmission_file',
+            'filearea' => ASSIGNSUBMISSION_FILE_FILEAREA,
+            'itemid' => $submission->id,
+            'filepath' => '/',
+            'filename' => 'myassignmnent.pdf'
+        );
+        $fi = $fs->create_file_from_string($dummy, 'Content of ' . $dummy->filename);
+        $dummy = (object) array(
+            'contextid' => $context->id,
+            'component' => 'assignsubmission_file',
+            'filearea' => ASSIGNSUBMISSION_FILE_FILEAREA,
+            'itemid' => $submission->id,
+            'filepath' => '/',
+            'filename' => 'myassignmnent.png'
+        );
+        $fi2 = $fs->create_file_from_string($dummy, 'Content of ' . $dummy->filename);
+        $files = $fs->get_area_files($context->id, 'assignsubmission_file', ASSIGNSUBMISSION_FILE_FILEAREA,
+            $submission->id, 'id', false);
+
+        $data = new \stdClass();
+        $plugin = $assign->get_submission_plugin_by_type('file');
+        $sink = $this->redirectEvents();
+        $plugin->save($submission, $data);
+        $events = $sink->get_events();
+
+        $this->assertCount(2, $events);
+        // We want to test the last event fired.
+        $event = $events[1];
+        $this->assertInstanceOf('\assignsubmission_file\event\submission_created', $event);
+        $this->assertEquals($context->id, $event->contextid);
+        $this->assertEquals($course->id, $event->courseid);
+        $this->assertEquals($submission->id, $event->other['submissionid']);
+        $this->assertEquals($submission->attemptnumber, $event->other['submissionattempt']);
+        $this->assertEquals($submission->status, $event->other['submissionstatus']);
+        $this->assertEquals($submission->userid, $event->relateduserid);
+    }
+
+    /**
+     * Test that the submission_updated event is fired when a file submission is saved when an existing submission already exists.
+     */
+    public function test_submission_updated(): void {
+        $this->resetAfterTest();
+
+        $course = $this->getDataGenerator()->create_course();
+        $student = $this->getDataGenerator()->create_and_enrol($course, 'student');
+        $assign = $this->create_instance($course);
+        $context = $assign->get_context();
+
+        $this->setUser($student->id);
+        $submission = $assign->get_user_submission($student->id, true);
+
+        $fs = get_file_storage();
+        $dummy = (object) array(
+            'contextid' => $context->id,
+            'component' => 'assignsubmission_file',
+            'filearea' => ASSIGNSUBMISSION_FILE_FILEAREA,
+            'itemid' => $submission->id,
+            'filepath' => '/',
+            'filename' => 'myassignmnent.pdf'
+        );
+        $fi = $fs->create_file_from_string($dummy, 'Content of ' . $dummy->filename);
+        $dummy = (object) array(
+            'contextid' => $context->id,
+            'component' => 'assignsubmission_file',
+            'filearea' => ASSIGNSUBMISSION_FILE_FILEAREA,
+            'itemid' => $submission->id,
+            'filepath' => '/',
+            'filename' => 'myassignmnent.png'
+        );
+        $fi2 = $fs->create_file_from_string($dummy, 'Content of ' . $dummy->filename);
+        $files = $fs->get_area_files($context->id, 'assignsubmission_file', ASSIGNSUBMISSION_FILE_FILEAREA,
+            $submission->id, 'id', false);
+
+        $data = new \stdClass();
+        $plugin = $assign->get_submission_plugin_by_type('file');
+        $sink = $this->redirectEvents();
+        // Create a submission.
+        $plugin->save($submission, $data);
+        // Update a submission.
+        $plugin->save($submission, $data);
+        $events = $sink->get_events();
+
+        $this->assertCount(4, $events);
+        // We want to test the last event fired.
+        $event = $events[3];
+        $this->assertInstanceOf('\assignsubmission_file\event\submission_updated', $event);
+        $this->assertEquals($context->id, $event->contextid);
+        $this->assertEquals($course->id, $event->courseid);
+        $this->assertEquals($submission->id, $event->other['submissionid']);
+        $this->assertEquals($submission->attemptnumber, $event->other['submissionattempt']);
+        $this->assertEquals($submission->status, $event->other['submissionstatus']);
+        $this->assertEquals($submission->userid, $event->relateduserid);
+    }
+
+}

mod/assign/submission/file/tests/generator/lib.php

@@ -0,0 +1,69 @@
+<?php
+// This file is part of Moodle - http://moodle.org/
+//
+// Moodle is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Moodle is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+
+require_once("{$CFG->dirroot}/mod/assign/tests/generator/assignsubmission_subplugin_generator.php");
+
+/**
+ * Online Text assignment submission subplugin data generator.
+ *
+ * @package assignsubmission_file
+ * @category test
+ * @copyright 2021 Andrew Lyons <andrew@nicols.co.uk>
+ * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+class assignsubmission_file_generator extends assignsubmission_subplugin_generator {
+    /**
+     * Add submission data in the correct format for a call to `assign::save_submission()` from a table containing
+     * submission data for a single activity.
+     *
+     * Data should be added to the $submission object passed into the function.
+     *
+     * @param stdClass $submission The submission record to be modified
+     * @param assign $assign The assignment being submitted to
+     * @param array $data The data received
+     */
+    public function add_submission_data(stdClass $submission, assign $assign, array $data): void {
+        global $CFG;
+
+        if (array_key_exists('file', $data)) {
+            $files = explode(',', $data['file']);
+            $itemid = file_get_unused_draft_itemid();
+
+            $fs = get_file_storage();
+
+            foreach ($files as $filepath) {
+                // All paths are relative to $CFG->dirroot.
+                $filepath = trim($filepath);
+                $filepath = "{$CFG->dirroot}/{$filepath}";
+                $filename = basename($filepath);
+
+                $fs->create_file_from_pathname((object) [
+                    'itemid' => $itemid,
+                    'contextid' => context_user::instance($submission->userid)->id,
+                    'component' => 'user',
+                    'filearea' => 'draft',
+                    'filepath' => '/',
+                    'filename' => $filename,
+                ], $filepath);
+            }
+            $submission->files_filemanager = $itemid;
+
+            $submission->file_editor = [
+                'itemid' => $itemid,
+            ];
+        }
+    }
+}

mod/assign/submission/file/tests/locallib_test.php

@@ -0,0 +1,230 @@
+<?php
+// This file is part of Moodle - http://moodle.org/
+//
+// Moodle is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Moodle is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+
+namespace assignsubmission_file;
+
+use mod_assign_test_generator;
+
+defined('MOODLE_INTERNAL') || die();
+
+global $CFG;
+require_once($CFG->dirroot . '/mod/assign/tests/generator.php');
+
+/**
+ * Unit tests for mod/assign/submission/file/locallib.php
+ *
+ * @package    assignsubmission_file
+ * @copyright  2016 Cameron Ball
+ * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+final class locallib_test extends \advanced_testcase {
+
+    // Use the generator helper.
+    use mod_assign_test_generator;
+
+    /**
+     * Test submission_is_empty
+     *
+     * @dataProvider submission_is_empty_testcases
+     * @param string $data The file submission data
+     * @param bool $expected The expected return value
+     */
+    public function test_submission_is_empty($data, $expected): void {
+        $this->resetAfterTest();
+
+        $course = $this->getDataGenerator()->create_course();
+        $student = $this->getDataGenerator()->create_and_enrol($course, 'student');
+        $assign = $this->create_instance($course, [
+                'assignsubmission_file_enabled' => 1,
+                'assignsubmission_file_maxfiles' => 12,
+                'assignsubmission_file_maxsizebytes' => 10,
+            ]);
+
+        $this->setUser($student->id);
+
+        $itemid = file_get_unused_draft_itemid();
+        $submission = (object)['files_filemanager' => $itemid];
+        $plugin = $assign->get_submission_plugin_by_type('file');
+
+        if ($data) {
+            $data += ['contextid' => \context_user::instance($student->id)->id, 'itemid' => $itemid];
+            $fs = get_file_storage();
+            $fs->create_file_from_string((object)$data, 'Content of ' . $data['filename']);
+        }
+
+        $result = $plugin->submission_is_empty($submission);
+        $this->assertTrue($result === $expected);
+    }
+
+    /**
+     * Test that an empty directory is is not detected as a valid submission by submission_is_empty.
+     */
+    public function test_submission_is_empty_directory_only(): void {
+        $this->resetAfterTest();
+        $course = $this->getDataGenerator()->create_course();
+        $student = $this->getDataGenerator()->create_and_enrol($course, 'student');
+        $assign = $this->create_instance($course, [
+                'assignsubmission_file_enabled' => 1,
+                'assignsubmission_file_maxfiles' => 12,
+                'assignsubmission_file_maxsizebytes' => 10,
+            ]);
+        $this->setUser($student->id);
+        $itemid = file_get_unused_draft_itemid();
+        $submission = (object)['files_filemanager' => $itemid];
+        $plugin = $assign->get_submission_plugin_by_type('file');
+        $fs = get_file_storage();
+        $fs->create_directory(
+                \context_user::instance($student->id)->id,
+                'user',
+                'draft',
+                $itemid,
+                '/subdirectory/'
+        );
+
+        $this->assertTrue($plugin->submission_is_empty($submission));
+    }
+
+    /**
+     * Test new_submission_empty
+     *
+     * @dataProvider submission_is_empty_testcases
+     * @param string $data The file submission data
+     * @param bool $expected The expected return value
+     */
+    public function test_new_submission_empty($data, $expected): void {
+        $this->resetAfterTest();
+
+        $course = $this->getDataGenerator()->create_course();
+        $student = $this->getDataGenerator()->create_and_enrol($course, 'student');
+        $assign = $this->create_instance($course, [
+                'assignsubmission_file_enabled' => 1,
+                'assignsubmission_file_maxfiles' => 12,
+                'assignsubmission_file_maxsizebytes' => 10,
+            ]);
+
+        $this->setUser($student);
+
+        $itemid = file_get_unused_draft_itemid();
+        $submission = (object) ['files_filemanager' => $itemid];
+
+        if ($data) {
+            $data += ['contextid' => \context_user::instance($student->id)->id, 'itemid' => $itemid];
+            $fs = get_file_storage();
+            $fs->create_file_from_string((object)$data, 'Content of ' . $data['filename']);
+        }
+
+        $result = $assign->new_submission_empty($submission);
+        $this->assertTrue($result === $expected);
+    }
+
+    /**
+     * Test that an empty directory is is not detected as a valid submission by new_submission_is_empty.
+     */
+    public function test_new_submission_empty_directory_only(): void {
+        $this->resetAfterTest();
+        $course = $this->getDataGenerator()->create_course();
+        $student = $this->getDataGenerator()->create_and_enrol($course, 'student');
+        $assign = $this->create_instance($course, [
+                'assignsubmission_file_enabled' => 1,
+                'assignsubmission_file_maxfiles' => 12,
+                'assignsubmission_file_maxsizebytes' => 10,
+            ]);
+        $this->setUser($student->id);
+        $itemid = file_get_unused_draft_itemid();
+        $submission = (object)['files_filemanager' => $itemid];
+        $plugin = $assign->get_submission_plugin_by_type('file');
+        $fs = get_file_storage();
+        $fs->create_directory(
+                \context_user::instance($student->id)->id,
+                'user',
+                'draft',
+                $itemid,
+                '/subdirectory/'
+        );
+
+        $this->assertTrue($assign->new_submission_empty($submission));
+    }
+
+    /**
+     * Dataprovider for the test_submission_is_empty testcase
+     *
+     * @return array of testcases
+     */
+    public static function submission_is_empty_testcases(): array {
+        return [
+            'With file' => [
+                [
+                    'component' => 'user',
+                    'filearea' => 'draft',
+                    'filepath' => '/',
+                    'filename' => 'not_a_virus.exe'
+                ],
+                false
+            ],
+            'With file in directory' => [
+                [
+                    'component' => 'user',
+                    'filearea' => 'draft',
+                    'filepath' => '/subdir/',
+                    'filename' => 'not_a_virus.exe'
+                ],
+                false
+            ],
+            'Without file' => [null, true]
+        ];
+    }
+
+    /**
+     * Test getting files from plugin submission
+     */
+    public function test_get_files(): void {
+        $this->resetAfterTest();
+
+        $course = $this->getDataGenerator()->create_course();
+        $student = $this->getDataGenerator()->create_and_enrol($course, 'student');
+        $assign = $this->create_instance($course, [
+            'assignsubmission_file_enabled' => 1,
+            'assignsubmission_file_maxfiles' => 2,
+            'assignsubmission_file_maxsizebytes' => 512,
+        ]);
+
+        // Switch to student, create some dummy files, and submit data to plugin.
+        $this->setUser($student);
+        $submission = $assign->get_user_submission($student->id, true);
+
+        $filerecord = [
+            'contextid' => $assign->get_context()->id,
+            'component' => 'assignsubmission_file',
+            'filearea' => ASSIGNSUBMISSION_FILE_FILEAREA,
+            'itemid' => $submission->id,
+            'filepath' => '/',
+        ];
+
+        get_file_storage()->create_file_from_string($filerecord + ['filename' => 'File 1.txt'], 'File One');
+        get_file_storage()->create_file_from_string($filerecord + ['filename' => 'File 2.txt'], 'File Two');
+
+        /** @var \assign_submission_file $plugin */
+        $plugin = $assign->get_submission_plugin_by_type('file');
+        $plugin->save($submission, (object) []);
+
+        // Ensure we retrieve back list of file submissions, deterministically ordered.
+        $files = $plugin->get_files($submission, $student);
+        $this->assertSame([
+            '/File 1.txt' => 'File 1.txt',
+            '/File 2.txt' => 'File 2.txt',
+        ], array_map(fn(\stored_file $f) => $f->get_filename(), $files));
+    }
+}

mod/assign/submission/file/tests/privacy/provider_test.php

@@ -0,0 +1,249 @@
+<?php
+// This file is part of Moodle - http://moodle.org/
+//
+// Moodle is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Moodle is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+
+/**
+ * Unit tests for assignsubmission_file.
+ *
+ * @package    assignsubmission_file
+ * @copyright  2018 Adrian Greeve <adrian@moodle.com>
+ * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+namespace assignsubmission_file\privacy;
+
+defined('MOODLE_INTERNAL') || die();
+
+global $CFG;
+require_once($CFG->dirroot . '/mod/assign/tests/privacy/provider_test.php');
+
+/**
+ * Unit tests for mod/assign/submission/file/classes/privacy/
+ *
+ * @copyright  2018 Adrian Greeve <adrian@moodle.com>
+ * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+class provider_test extends \mod_assign\privacy\provider_test {
+
+    /**
+     * Convenience function for creating feedback data.
+     *
+     * @param  object   $assign         assign object
+     * @param  stdClass $student        user object
+     * @param  string   $filename       filename for the file submission
+     * @return array   Submission plugin object and the submission object.
+     */
+    protected function create_file_submission($assign, $student, $filename) {
+        global $CFG;
+        // Create a file submission with the test pdf.
+        $submission = $assign->get_user_submission($student->id, true);
+
+        $this->setUser($student->id);
+
+        $fs = get_file_storage();
+        $pdfsubmission = (object) array(
+            'contextid' => $assign->get_context()->id,
+            'component' => 'assignsubmission_file',
+            'filearea' => ASSIGNSUBMISSION_FILE_FILEAREA,
+            'itemid' => $submission->id,
+            'filepath' => '/',
+            'filename' => $filename
+        );
+        $sourcefile = $CFG->dirroot.'/mod/assign/feedback/editpdf/tests/fixtures/submission.pdf';
+        $fi = $fs->create_file_from_pathname($pdfsubmission, $sourcefile);
+
+        $data = new \stdClass();
+        $plugin = $assign->get_submission_plugin_by_type('file');
+        $plugin->save($submission, $data);
+
+        return [$plugin, $submission];
+    }
+
+    /**
+     * Quick test to make sure that get_metadata returns something.
+     */
+    public function test_get_metadata(): void {
+        $collection = new \core_privacy\local\metadata\collection('assignsubmission_file');
+        $collection = \assignsubmission_file\privacy\provider::get_metadata($collection);
+        $this->assertNotEmpty($collection);
+    }
+
+    /**
+     * Test that submission files are exported for a user.
+     */
+    public function test_export_submission_user_data(): void {
+        $this->resetAfterTest();
+        // Create course, assignment, submission, and then a feedback comment.
+        $course = $this->getDataGenerator()->create_course();
+        // Student.
+        $user1 = $this->getDataGenerator()->create_user();
+        // Teacher.
+        $user2 = $this->getDataGenerator()->create_user();
+        $this->getDataGenerator()->enrol_user($user1->id, $course->id, 'student');
+        $this->getDataGenerator()->enrol_user($user2->id, $course->id, 'editingteacher');
+        $assign = $this->create_instance(['course' => $course]);
+
+        $context = $assign->get_context();
+
+        $studentfilename = 'user1file.pdf';
+        list($plugin, $submission) = $this->create_file_submission($assign, $user1, $studentfilename);
+
+        $writer = \core_privacy\local\request\writer::with_context($context);
+        $this->assertFalse($writer->has_any_data());
+
+        // The student should have a file submission.
+        $exportdata = new \mod_assign\privacy\assign_plugin_request_data($context, $assign, $submission, ['Attempt 1']);
+        \assignsubmission_file\privacy\provider::export_submission_user_data($exportdata);
+        // print_object($writer);
+        $storedfile = $writer->get_files(['Attempt 1'])['user1file.pdf'];
+        $this->assertInstanceOf('stored_file', $storedfile);
+        $this->assertEquals($studentfilename, $storedfile->get_filename());
+    }
+
+    /**
+     * Test that all submission files are deleted for this context.
+     */
+    public function test_delete_submission_for_context(): void {
+        $this->resetAfterTest();
+        // Create course, assignment, submission, and then a feedback comment.
+        $course = $this->getDataGenerator()->create_course();
+        // Student.
+        $user1 = $this->getDataGenerator()->create_user();
+        $user2 = $this->getDataGenerator()->create_user();
+
+        $this->getDataGenerator()->enrol_user($user1->id, $course->id, 'student');
+        $this->getDataGenerator()->enrol_user($user2->id, $course->id, 'student');
+
+        $assign = $this->create_instance(['course' => $course]);
+
+        $context = $assign->get_context();
+
+        $studentfilename = 'user1file.pdf';
+        list($plugin, $submission) = $this->create_file_submission($assign, $user1, $studentfilename);
+        $student2filename = 'user2file.pdf';
+        list($plugin2, $submission2) = $this->create_file_submission($assign, $user2, $studentfilename);
+
+        // Only need the context and assign object in this plugin for this operation.
+        $requestdata = new \mod_assign\privacy\assign_plugin_request_data($context, $assign);
+        \assignsubmission_file\privacy\provider::delete_submission_for_context($requestdata);
+        // This checks that there are no files in this submission.
+        $this->assertTrue($plugin->is_empty($submission));
+        $this->assertTrue($plugin2->is_empty($submission2));
+    }
+
+    /**
+     * Test that the comments for a user are deleted.
+     */
+    public function test_delete_submission_for_userid(): void {
+        $this->resetAfterTest();
+        // Create course, assignment, submission, and then a feedback comment.
+        $course = $this->getDataGenerator()->create_course();
+        // Student.
+        $user1 = $this->getDataGenerator()->create_user();
+        $user2 = $this->getDataGenerator()->create_user();
+
+        $this->getDataGenerator()->enrol_user($user1->id, $course->id, 'student');
+        $this->getDataGenerator()->enrol_user($user2->id, $course->id, 'student');
+
+        $assign = $this->create_instance(['course' => $course]);
+
+        $context = $assign->get_context();
+
+        $studentfilename = 'user1file.pdf';
+        list($plugin, $submission) = $this->create_file_submission($assign, $user1, $studentfilename);
+        $student2filename = 'user2file.pdf';
+        list($plugin2, $submission2) = $this->create_file_submission($assign, $user2, $studentfilename);
+
+        // Only need the context and assign object in this plugin for this operation.
+        $requestdata = new \mod_assign\privacy\assign_plugin_request_data($context, $assign, $submission, [], $user1);
+        \assignsubmission_file\privacy\provider::delete_submission_for_userid($requestdata);
+        // This checks that there are no files in this submission.
+        $this->assertTrue($plugin->is_empty($submission));
+        // There should be files here.
+        $this->assertFalse($plugin2->is_empty($submission2));
+    }
+
+    /**
+     * Test deletion of bulk submissions for a context.
+     */
+    public function test_delete_submissions(): void {
+        global $DB;
+
+        $this->resetAfterTest();
+        // Create course, assignment, submission, and then a feedback comment.
+        $course = $this->getDataGenerator()->create_course();
+        // Student.
+        $user1 = $this->getDataGenerator()->create_user();
+        $user2 = $this->getDataGenerator()->create_user();
+        $user3 = $this->getDataGenerator()->create_user();
+        $user4 = $this->getDataGenerator()->create_user();
+
+        $this->getDataGenerator()->enrol_user($user1->id, $course->id, 'student');
+        $this->getDataGenerator()->enrol_user($user2->id, $course->id, 'student');
+        $this->getDataGenerator()->enrol_user($user3->id, $course->id, 'student');
+        $this->getDataGenerator()->enrol_user($user4->id, $course->id, 'student');
+
+        $assign1 = $this->create_instance(['course' => $course]);
+        $assign2 = $this->create_instance(['course' => $course]);
+
+        $context1 = $assign1->get_context();
+        $context2 = $assign2->get_context();
+
+        $student1filename = 'user1file.pdf';
+        list($plugin1, $submission1) = $this->create_file_submission($assign1, $user1, $student1filename);
+        $student2filename = 'user2file.pdf';
+        list($plugin2, $submission2) = $this->create_file_submission($assign1, $user2, $student2filename);
+        $student3filename = 'user3file.pdf';
+        list($plugin3, $submission3) = $this->create_file_submission($assign1, $user3, $student3filename);
+        $student4filename = 'user4file.pdf';
+        list($plugin4, $submission4) = $this->create_file_submission($assign2, $user4, $student4filename);
+        $student5filename = 'user5file.pdf';
+        list($plugin5, $submission5) = $this->create_file_submission($assign2, $user3, $student5filename);
+
+        $submissionids = [
+            $submission1->id,
+            $submission3->id
+        ];
+
+        $userids = [
+            $user1->id,
+            $user3->id
+        ];
+
+        $data = $DB->get_records('files', ['contextid' => $context1->id, 'component' => 'assignsubmission_file']);
+        $this->assertCount(6, $data);
+
+        $data = $DB->get_records('assignsubmission_file', ['assignment' => $assign1->get_instance()->id]);
+        $this->assertCount(3, $data);
+
+        // Records in the second assignment (not being touched).
+        $data = $DB->get_records('assignsubmission_file', ['assignment' => $assign2->get_instance()->id]);
+        $this->assertCount(2, $data);
+
+        $deletedata = new \mod_assign\privacy\assign_plugin_request_data($context1, $assign1);
+        $deletedata->set_userids($userids);
+        $deletedata->populate_submissions_and_grades();
+        \assignsubmission_file\privacy\provider::delete_submissions($deletedata);
+        $data = $DB->get_records('files', ['contextid' => $context1->id, 'component' => 'assignsubmission_file']);
+        $this->assertCount(2, $data);
+
+        // Submission 1 and 3 have been removed. We should be left with submission2.
+        $data = $DB->get_records('assignsubmission_file', ['assignment' => $assign1->get_instance()->id]);
+        $this->assertCount(1, $data);
+
+        // This should be untouched.
+        $data = $DB->get_records('assignsubmission_file', ['assignment' => $assign2->get_instance()->id]);
+        $this->assertCount(2, $data);
+    }
+}

mod/assign/submission/file/version.php

@@ -0,0 +1,29 @@
+<?php
+// This file is part of Moodle - http://moodle.org/
+//
+// Moodle is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Moodle is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+
+/**
+ * This file contains the version information for the file submission plugin
+ *
+ * @package    assignsubmission_file
+ * @copyright 2012 NetSpot {@link http://www.netspot.com.au}
+ * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+
+defined('MOODLE_INTERNAL') || die();
+
+$plugin->version   = 2024042200;
+$plugin->requires  = 2024041600;
+$plugin->component = 'assignsubmission_file';