From 4e9ff06cedd7632e23e71098daf475d6e59ada69 Mon Sep 17 00:00:00 2001
From: "oluyemi.a.simbrellang.com" <oluyemi.a@simbrellang.com>
Date: Thu, 17 Apr 2025 17:41:09 +0100
Subject: [PATCH] some improvements on endpoints

---
 app/integrations/simbrella.py | 13 +++++--------
 app/routes/autocall.py        | 11 ++++++-----
 2 files changed, 11 insertions(+), 13 deletions(-)

diff --git a/app/integrations/simbrella.py b/app/integrations/simbrella.py
index e49c3df..920ea9f 100644
--- a/app/integrations/simbrella.py
+++ b/app/integrations/simbrella.py
@@ -121,10 +121,11 @@ class SimbrellaClient:
     def verify_transaction():
         try:
 
-            return {
+            data = {
                 "status": "00",
                 "message": "Transaction verified"
             }
+            return ResponseHelper.success(data, "Successful")
 
         except Exception as e:
             logger.info(f"Failed to call TransactionVerify endpoint: {e}")
@@ -136,7 +137,7 @@ class SimbrellaClient:
         try:
             logger.info(f"Here is your Disbursement Request data ***** : {data}")
 
-            return data
+            return ResponseHelper.success(data, "Successful")
 
         except Exception as e:
             logger.info(f"Failed to call Disbursement endpoint: {e}")
@@ -148,7 +149,7 @@ class SimbrellaClient:
         try:
             logger.info(f"Here is your Payment Callback Request data ***** : {data}")
 
-            return data
+            return ResponseHelper.success(data, "Successful")
 
         except Exception as e:
             logger.info(f"Failed to call Payment Callback endpoint: {e}")
@@ -167,16 +168,12 @@ class SimbrellaClient:
                 logger.info(f"Here is your Penal Charge Request data ****** : {data}")
                 response = requests.post(api_url, json=data, timeout=10, headers=get_headers())
                 logger.info(f"Penal Charge response: {response.json()}")
+                return ResponseHelper.success(response.json(), "Successful")
 
             except Exception as e:
                 logger.info(f"Failed to call Penal Charge endpoint: {e}")
                 return ResponseHelper.error("An error occurred", 500)
 
-            return ResponseHelper.success({
-                  "resultCode": "00",
-                  "resultDescription": "Penal charge debited successfully"
-                }, "Successful")
-
         except Exception as e:
             logger.info(f"Failed to call Penal Charge endpoint: {e}")
             raise
\ No newline at end of file
diff --git a/app/routes/autocall.py b/app/routes/autocall.py
index 42335f3..230cd4e 100644
--- a/app/routes/autocall.py
+++ b/app/routes/autocall.py
@@ -1,6 +1,7 @@
 from flask import Blueprint, request, jsonify, current_app
 import requests
 from app.config import settings
+from app.helpers.response_helper import ResponseHelper
 from app.utils.auth import get_headers
 from app.utils.logger import logger
 from app.integrations.simbrella import SimbrellaClient
@@ -14,7 +15,7 @@ def verify_transaction():
 
     response = SimbrellaClient.verify_transaction()
 
-    return jsonify(response), 200
+    return response
 
 @autocall_bp.route("/refresh-disbursement", methods=["GET"])
 def disbursement():
@@ -23,7 +24,7 @@ def disbursement():
 
     response = SimbrellaClient.verify_transaction()
 
-    return jsonify(response), 200
+    return response
 
 
 @autocall_bp.route("/payment-callback", methods=["POST"])
@@ -33,13 +34,13 @@ def payment_callback():
 
     response = SimbrellaClient.payment_callback(data)
 
-    return jsonify(response), 200
+    return response
 
 @autocall_bp.route("/penal-charge", methods=["POST"])
 def penal_charge():
     data = request.get_json()
     logger.info(f"Calling Penal Charge Endpoints")
 
-    response = SimbrellaClient.penal_charge(data)
+    response = SimbrellaClient.penal_charge(data[0])
 
-    return jsonify(response), 200
\ No newline at end of file
+    return response
\ No newline at end of file
-- 
2.34.1