diff --git a/app/config.py b/app/config.py index 5c67b11..2b2d4e1 100644 --- a/app/config.py +++ b/app/config.py @@ -54,7 +54,8 @@ class Config: MAIL_USE_SSL = os.getenv('MAIL_USE_SSL', 'False').lower() in ('true', '1', 'yes') MAIL_DEFAULT_SENDER = ('FirstAdvance', 'firstadvance@dynamikservices.tech') MAIL_RECEIVER= os.getenv('MAIL_RECEIVER', 'chinenyeumeaku@gmail.com,umeakuchinenye@gmail.com') - + + BANK_CALL_API_TIME_OUT = os.getenv("BANK_CALL_API_TIME_OUT", 100) BANK_CALL_BASE_URL = os.getenv("BANK_CALL_BASE_URL", "https://bank-emulator.dev.simbrellang.net/api") BANK_CALL_SMS_BASE_URL= os.getenv("BANK_CALL_SMS_BASE_URL","https://first-advance-middleware-develop.fbn-devops-dev-asenv.appserviceenvironment.net/SMS") BANK_CALL_DISBURSE_LOAN_ENDPOINT = os.getenv("BANK_CALL_DISBURSE_LOAN_ENDPOINT","/DisburseLoan") diff --git a/app/integrations/simbrella.py b/app/integrations/simbrella.py index a7f42dc..83a37e7 100644 --- a/app/integrations/simbrella.py +++ b/app/integrations/simbrella.py @@ -33,6 +33,7 @@ class SimbrellaClient: BANK_CALL_COLLECT_LOAN_ENDPOINT = settings.BANK_CALL_COLLECT_LOAN_ENDPOINT BANK_CALL_TRANSACTION_VERIFY = settings.BANK_CALL_TRANSACTION_VERIFY BANK_HEALTH_CHECK_ENDPOINT = settings.BANK_HEALTH_CHECK_ENDPOINT + BANK_CALL_API_TIME_OUT = settings.BANK_CALL_API_TIME_OUT @staticmethod def disburse_loan(data): @@ -126,8 +127,8 @@ class SimbrellaClient: # } # ''' try: - logger.info(f"Here is your Disbursement Request data ****** : {disbursement_data}") - response = requests.post(api_url, json=disbursement_data, timeout=10, headers=get_headers()) + logger.info(f"Calling Bank Disbursement with Request data ****** : {disbursement_data}") + response = requests.post(api_url, json=disbursement_data, timeout=SimbrellaClient.BANK_CALL_API_TIME_OUT, headers=get_headers()) logger.info(f"Call to bank end point returned with Here is your Disbursement Request data ****** : {disbursement_data}") if response.status_code == 404: logger.error("") @@ -225,7 +226,7 @@ class SimbrellaClient: # ''' try: logger.info(f"Here is your TransactionVerify Request data ****** : {verify_data}") - response = requests.post(api_url, json=verify_data, timeout=10, headers=get_headers()) + response = requests.post(api_url, json=verify_data, timeout=SimbrellaClient.BANK_CALL_API_TIME_OUT, headers=get_headers()) if response.status_code == 404: logger.error("Received 404 from external service") return ResponseHelper.error("Verify Service url not found (404)", status_code=404) @@ -246,7 +247,7 @@ class SimbrellaClient: try: - sms_response = requests.post(sms_url, json=sms_data, timeout=10, headers=get_headers()) + sms_response = requests.post(sms_url, json=sms_data, timeout=SimbrellaClient.BANK_CALL_API_TIME_OUT, headers=get_headers()) sms_response.raise_for_status() # Raise an exception for 4xx or 5xx status codes result = sms_response.json() @@ -326,7 +327,7 @@ class SimbrellaClient: collect_loan_data = CollectLoanHelper._build_collect_loan_payload(loan_data, repayment_data, data, collectionMethod) try: logger.info(f"Sending CollectLoan request............ {collect_loan_data}") - response = requests.post(api_url, json=collect_loan_data, timeout=90, headers=get_headers()) + response = requests.post(api_url, json=collect_loan_data, timeout=SimbrellaClient.BANK_CALL_API_TIME_OUT, headers=get_headers()) logger.info(f"HTTP response object: {response}") if response.status_code == 404: @@ -455,7 +456,7 @@ class SimbrellaClient: try: logger.info(f"Here is your Penal Charge Request data ****** : {data}") - response = requests.post(api_url, json=data, timeout=10, headers=get_headers()) + response = requests.post(api_url, json=data, timeout=SimbrellaClient.BANK_CALL_API_TIME_OUT, headers=get_headers()) logger.info(f"Penal Charge response: {response.json()}") return ResponseHelper.success(response.json(), "Successful")