[update]: Resposes

app/api/services/repayment.py

@@ -1,6 +1,7 @@
 from flask import request, jsonify
 from marshmallow import ValidationError
 from app.api.enums.loan_status import LoanStatus
+from app.api.helpers.response_helper import ResponseHelper
 from app.models import Repayment
 from app.models.customer import Customer
 from app.models.loan import Loan
@@ -49,9 +50,7 @@ class RepaymentService(BaseService):
 
                     if not repayment:
                         logger.error(f"Failed to save repayment details")
-                        return jsonify({
-                            "message": "Failed to save repayment details."
-                        }), 400
+                        return ResponseHelper.error(result_description="Failed to save repayment details.")
                 
                     
                     #Update Loan status
@@ -61,13 +60,9 @@ class RepaymentService(BaseService):
 
                     if not transaction:
                         logger.error(f"Failed to log transaction")
-                        return jsonify({
-                            "message": "Failed to log transaction."
-                        }), 400   
+                        return ResponseHelper.error(result_description="Failed to log transaction.") 
                 else: 
-                    return jsonify({
-                            "message": "Invalid Customer or Account"
-                        }), 400
+                    return ResponseHelper.error(result_description="Invalid Customer or Account")
         
 
 
@@ -76,43 +71,28 @@ class RepaymentService(BaseService):
                     "transactionId": transaction_id,
                     "customerId": customer_id,
                     "productId": product_id,
-                    "debtId": loan_id,
-                    "resultCode": "00",
-                    "resultDescription": "Successful"
+                    "debtId": loan_id
                 }
 
-                # return ResponseHelper.success(
-                #     data=response_data,
-                #     message="Repayment processed successfully"
-                # )
-
                 # Call Kafka in a background thread
                 thread = Thread(target=RepaymentService.async_send_to_kafka, args=(response_data, request_id, "LOAN_REPAYMENT"))
                 thread.start()
 
                 db.session.commit()
-                return response_data
+                return ResponseHelper.success(data=response_data)
 
         except ValidationError as err:
 
             logger.error(f"Validation Error: {getattr(err, 'messages', str(err))}")
-            db.session.rollback() 
-
-            return jsonify({
-                "message": "Validation exception"
-                }) , 422
+            db.session.rollback()
+            return ResponseHelper.unprocessable_entity(result_description="Validation exception")
         
         except  ValueError as err:
             logger.error(f"{getattr(err, 'messages', str(err))}")
-            db.session.rollback() 
-
-            return jsonify({
-                "message": str(err)
-                }) , 400
+            db.session.rollback()
+            return ResponseHelper.error(result_description=str(err))
 
         except Exception as e:
             logger.error(f"An error occurred: {str(e)}", exc_info=True)
-            db.session.rollback() 
-            return jsonify({
-                "message": "Internal Server Error"
-                }) , 500
+            db.session.rollback()
+            return ResponseHelper.internal_server_error()