From 87f1fa2152d82e81f7c1ab634dae8c36287fb332 Mon Sep 17 00:00:00 2001 From: VivianDee <115420678+VivianDee@users.noreply.github.com> Date: Thu, 10 Apr 2025 12:35:46 +0100 Subject: [PATCH] [fix]: save loan --- app/api/schemas/provide_loan.py | 4 ++-- app/api/services/provide_loan.py | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/app/api/schemas/provide_loan.py b/app/api/schemas/provide_loan.py index 4d85a3b..43c1044 100644 --- a/app/api/schemas/provide_loan.py +++ b/app/api/schemas/provide_loan.py @@ -8,8 +8,8 @@ class ProvideLoanSchema(Schema): customerId = fields.Str(required=True) accountId = fields.Str(required=True) msisdn = fields.Str(required=False) - # productId = fields.Str(required=True) - # lienAmount = fields.Float(required=True) + productId = fields.Str(required=True) + lienAmount = fields.Float(required=True) requestedAmount = fields.Float(required=True) collectionType = fields.Int(required=True) offerId = fields.Int(required=True) diff --git a/app/api/services/provide_loan.py b/app/api/services/provide_loan.py index 9833661..ad30b6b 100644 --- a/app/api/services/provide_loan.py +++ b/app/api/services/provide_loan.py @@ -34,6 +34,8 @@ class ProvideLoanService(BaseService): if (ProvideLoanService.validate_account_ownership(account_id = account_id, customer_id = customer_id)): + transaction = ProvideLoanService.log_transaction(validated_data = validated_data) + # Save the loan details here loan_id = f"loan_{transaction.id}" @@ -46,7 +48,7 @@ class ProvideLoanService(BaseService): status="active" ) - transaction = ProvideLoanService.log_transaction(validated_data = validated_data) +