From d1b8d15f3138b96be292cf6db27b886ff634f2d1 Mon Sep 17 00:00:00 2001 From: VivianDee <115420678+VivianDee@users.noreply.github.com> Date: Thu, 29 May 2025 13:00:51 -0400 Subject: [PATCH 1/4] Update eligibility_check.py --- app/api/services/eligibility_check.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/app/api/services/eligibility_check.py b/app/api/services/eligibility_check.py index 5678b4f..5301d76 100644 --- a/app/api/services/eligibility_check.py +++ b/app/api/services/eligibility_check.py @@ -70,6 +70,12 @@ class EligibilityCheckService(BaseService): return ResponseHelper.error(result_description="RACCheck failed") response = response.json() + + logger.info(f"This is Response (from Eligibility Check): {str(response)}", exc_info=True) + + # Handle this error response + # 2025-05-29 16:23:18,685 - INFO - This is Response (Eligibility Check): {'data': None, 'responseCode': '04', 'responseMessage': 'Error!, Invalid Account Id or Customer Id supplied'} + rac_check = RACCheck.add_rac_check( customer_id = customer_id, From 10138f66f35b955f682ecb4fbc46da831f34d440 Mon Sep 17 00:00:00 2001 From: VivianDee <115420678+VivianDee@users.noreply.github.com> Date: Fri, 30 May 2025 08:25:40 -0400 Subject: [PATCH 2/4] Update eligibility_check.py --- app/api/services/eligibility_check.py | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/app/api/services/eligibility_check.py b/app/api/services/eligibility_check.py index 5301d76..0d3953a 100644 --- a/app/api/services/eligibility_check.py +++ b/app/api/services/eligibility_check.py @@ -76,6 +76,26 @@ class EligibilityCheckService(BaseService): # Handle this error response # 2025-05-29 16:23:18,685 - INFO - This is Response (Eligibility Check): {'data': None, 'responseCode': '04', 'responseMessage': 'Error!, Invalid Account Id or Customer Id supplied'} + # { + # "data": { + # "customerId": "244011885", + # "accountId": "TE45702360", + # "transactionId": "250526144645534567CC3B01", + # "racResponse": { + # "hasSalaryAccount": true, + # "bvnValidated": true, + # "crmsCheck": true, + # "creditBureauCheck": true, + # "hasPastDueLoan": true, + # "hasLien": true, + # "accountStatus": true, + # "noBouncedCheck": true, + # "isWhitelisted": true + # } + # }, + # "responseCode": "00", + # "responseMessage": "Operation Successful" + # } rac_check = RACCheck.add_rac_check( customer_id = customer_id, From 201fa4202ecc2a8ef88027dec788e90a96e9627d Mon Sep 17 00:00:00 2001 From: VivianDee <115420678+VivianDee@users.noreply.github.com> Date: Mon, 2 Jun 2025 08:07:15 -0400 Subject: [PATCH 3/4] Update eligibility_check.py --- app/api/services/eligibility_check.py | 38 +++++++-------------------- 1 file changed, 10 insertions(+), 28 deletions(-) diff --git a/app/api/services/eligibility_check.py b/app/api/services/eligibility_check.py index 0d3953a..f74202f 100644 --- a/app/api/services/eligibility_check.py +++ b/app/api/services/eligibility_check.py @@ -73,42 +73,24 @@ class EligibilityCheckService(BaseService): logger.info(f"This is Response (from Eligibility Check): {str(response)}", exc_info=True) - # Handle this error response - # 2025-05-29 16:23:18,685 - INFO - This is Response (Eligibility Check): {'data': None, 'responseCode': '04', 'responseMessage': 'Error!, Invalid Account Id or Customer Id supplied'} - - # { - # "data": { - # "customerId": "244011885", - # "accountId": "TE45702360", - # "transactionId": "250526144645534567CC3B01", - # "racResponse": { - # "hasSalaryAccount": true, - # "bvnValidated": true, - # "crmsCheck": true, - # "creditBureauCheck": true, - # "hasPastDueLoan": true, - # "hasLien": true, - # "accountStatus": true, - # "noBouncedCheck": true, - # "isWhitelisted": true - # } - # }, - # "responseCode": "00", - # "responseMessage": "Operation Successful" - # } + if not response or response['responseCode'] != '00': + + if response: + logger.error(f"{response['responseMessage']}") + + return ResponseHelper.error(result_description=f"Failed to save RACCheck") + + rack_checks_response = response['data']['racResponse'] + rac_check = RACCheck.add_rac_check( customer_id = customer_id, account_id = account_id, transaction_id = transaction.transaction_id, - data = response['racResponse'] + data = rack_checks_response ) - if not rac_check: - logger.error(f"Failed to save RACCheck") - return ResponseHelper.error(result_description="Failed to save RACCheck.") - rack_checks_response = response['racResponse'] # -----------------TIME FOR ANALYSIS TO REGISTER OFFER ---------------------- # eligible_offers = [] try: From c061c9b5a4cde39e73d0bdea5948ef1ed10648bf Mon Sep 17 00:00:00 2001 From: VivianDee <115420678+VivianDee@users.noreply.github.com> Date: Mon, 2 Jun 2025 08:16:12 -0400 Subject: [PATCH 4/4] Update eligibility_check.py --- app/api/services/eligibility_check.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/app/api/services/eligibility_check.py b/app/api/services/eligibility_check.py index f74202f..5670e1c 100644 --- a/app/api/services/eligibility_check.py +++ b/app/api/services/eligibility_check.py @@ -75,11 +75,11 @@ class EligibilityCheckService(BaseService): if not response or response['responseCode'] != '00': - + if response: logger.error(f"{response['responseMessage']}") - return ResponseHelper.error(result_description=f"Failed to save RACCheck") + return ResponseHelper.error(result_description=f"RACCheck failed") rack_checks_response = response['data']['racResponse'] @@ -89,9 +89,12 @@ class EligibilityCheckService(BaseService): transaction_id = transaction.transaction_id, data = rack_checks_response ) - -# -----------------TIME FOR ANALYSIS TO REGISTER OFFER ---------------------- + if not rac_check: + logger.error(f"Failed to save RACCheck") + return ResponseHelper.error(result_description="Failed to save RACCheck.") + + # -----------------TIME FOR ANALYSIS TO REGISTER OFFER ---------------------- # eligible_offers = [] try: eligible_offers = OfferAnalysis.decide_offer(