From 77165e2adfdf7e90943e82ba38b4833f0eb07129 Mon Sep 17 00:00:00 2001
From: VivianDee <115420678+VivianDee@users.noreply.github.com>
Date: Wed, 24 Sep 2025 14:48:57 +0100
Subject: [PATCH] Update config.py

---
 app/config.py | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/app/config.py b/app/config.py
index 35c509b..32a2569 100644
--- a/app/config.py
+++ b/app/config.py
@@ -30,14 +30,16 @@ DB_CONFIG = {
     "name": os.getenv("DATABASE_NAME"),
     "port": os.getenv("DATABASE_PORT", 10532),
     "host": os.getenv("DATABASE_HOST", "firstadvancedev"),
-    "sid": os.getenv("DATABASE_SID", "FREE")
+    "sid": os.getenv("DATABASE_SID", "FREE"),
+    "service_name": os.getenv("DATABASE_SERVICE_NAME", "firstadv")
 }
 
 
-DNS =  f"(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST={DB_CONFIG['host']})(PORT={DB_CONFIG['port']}))(CONNECT_DATA=(SID={DB_CONFIG['sid']})))"
+# DNS =  f"(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST={DB_CONFIG['host']})(PORT={DB_CONFIG['port']}))(CONNECT_DATA=(SID={DB_CONFIG['sid']})))"
     
 # Database Connection
-SQLALCHEMY_DATABASE_URI = (f"oracle+oracledb://{DB_CONFIG['user']}:{DB_CONFIG['password']}@{DNS}")
+# SQLALCHEMY_DATABASE_URI = (f"oracle+oracledb://{DB_CONFIG['user']}:{DB_CONFIG['password']}@{DNS}")
+SQLALCHEMY_DATABASE_URI = ( f"oracle+oracledb://{DB_CONFIG['user']}:{DB_CONFIG['password']}@{DB_CONFIG['host']}:{DB_CONFIG['port']}/?service_name={DB_CONFIG['service_name']}")
 
 
 # SQLAlchemy Configuration